Fix viewing compound volume annotations #8668
Conversation
📝 WalkthroughWalkthroughThis change documents a fix in the changelog for viewing volume annotation task results in compound view, adds error handling to the volume data merge operation, and makes the Changes
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.unreleased.md (1)
21-21: Fix typo in changelog entry.There's a spelling error in the changelog entry.
Apply this diff to fix the typo:
-- Fixed viewing the results of volume anotation tasks in compound view. [#8668](https://github.com/scalableminds/webknossos/pull/8668) +- Fixed viewing the results of volume annotation tasks in compound view. [#8668](https://github.com/scalableminds/webknossos/pull/8668)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.unreleased.md(1 hunks)webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/controllers/TSAnnotationController.scala(1 hunks)webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeTracingService.scala(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build-smoketest-push
- GitHub Check: frontend-tests
- GitHub Check: backend-tests
🔇 Additional comments (2)
webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/controllers/TSAnnotationController.scala (1)
189-189: Good addition of explicit error handling.Adding the error message to the
mergeVolumeDatacall improves error reporting and follows the Fox monadic pattern used throughout the codebase. This will help with debugging any merge failures.webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeTracingService.scala (1)
851-852: Excellent fix for boolean parameter confusion.Making the boolean parameters explicit with named arguments addresses the core issue mentioned in the PR objectives. This prevents positional argument errors and significantly improves code clarity, especially when dealing with multiple boolean parameters.
This is a great example of defensive programming that the compiler can now properly validate.
Compiler didn’t catch that we passed the bool to the wrong argument. - Create volume task type - Create task with this task type - In dashboard, get this task, annotate some, finish - In task list view, click view on this task - Should work (CompoundTask in URI) - fixes https://scm.slack.com/archives/C02H5T8Q08P/p1748888339790129 ------ - [x] Updated [changelog](../blob/master/CHANGELOG.unreleased.md#unreleased) - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md)
Compiler didn’t catch that we passed the bool to the wrong argument.
Steps to test (I tested):
Issues: