Skip to content

Conversation

knollengewaechs
Copy link
Contributor

@knollengewaechs knollengewaechs commented May 28, 2025

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open an annotation, add some trees (also within nested groups)
  • open their context menu -> duplicate tree
  • in the same group, a new tree with new nodes (same positions) should appear
  • all tree actions should be working on original and copied tree
  • check that NML import of skeletons is still working fine (as this uses the same action that was adjusted in this PR)

Issues:


(Please delete unneeded items, merge only when none are left open)

@knollengewaechs knollengewaechs self-assigned this May 28, 2025
Copy link
Contributor

coderabbitai bot commented May 28, 2025

📝 Walkthrough

"""

Walkthrough

A "Duplicate Tree" menu item was added to the tree context menu in the tree tab. Supporting logic was implemented by updating the addTreesAndGroupsAction, its reducer, and helper functions to allow trees to be added without assigning new group IDs, enabling duplication within the same group.

Changes

Files/Paths Change Summary
frontend/javascripts/viewer/model/actions/skeletontracing_actions.tsx addTreesAndGroupsAction updated: new assignTreeToNewGroupId parameter (default true), payload extended.
frontend/javascripts/viewer/model/reducers/skeletontracing_reducer.ts Reducer updated to handle assignNewGroupId from action and pass to helper.
frontend/javascripts/viewer/model/reducers/skeletontracing_reducer_helpers.ts addTreesAndGroups updated: new assignNewGroupId parameter controls group ID assignment for trees.
frontend/javascripts/viewer/view/right-border-tabs/trees_tab/tree_hierarchy_renderers.tsx "Duplicate Tree" menu item added; deep clone logic and dispatch using updated action.

Assessment against linked issues

Objective Addressed Explanation
Add "Duplicate Tree" menu item in tree tab context menu (#5291)
Allow duplication of a tree (deep clone, same group, new name) (#5291)
Update addTreesAndGroups to support duplication logic as described (#5291)

Suggested labels

frontend, backend

Suggested reviewers

  • philippotto

Poem

A tree now can duplicate,
With just a menu click—how great!
A copy blooms with name anew,
In the same group, its branches grew.
Rabbits cheer with coder glee,
For every tree, a backup tree! 🌳🐇
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5448763 and 87d54e2.

📒 Files selected for processing (1)
  • CHANGELOG.unreleased.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.unreleased.md
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-smoketest-push
  • GitHub Check: backend-tests
  • GitHub Check: frontend-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@knollengewaechs knollengewaechs marked this pull request as ready for review May 30, 2025 13:31
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, works great 👍 only see my one nitpick comment before merging.

@knollengewaechs knollengewaechs enabled auto-merge (squash) June 4, 2025 07:38
@knollengewaechs knollengewaechs merged commit c240321 into master Jun 4, 2025
5 checks passed
@knollengewaechs knollengewaechs deleted the duplicate-tree branch June 4, 2025 07:45
@coderabbitai coderabbitai bot mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate tree
2 participants