Bump backend dependencies, run codespell #8507
Conversation
📝 WalkthroughWalkthroughThis pull request makes several configuration and dependency updates. The changes include modifications to the spell-check configuration, an addition to the changelog for backend dependency upgrades, updates to Scala, SBT, and plugin versions in the build system, and multiple dependency version bumps. In addition, minor comment corrections were made in both JavaScript and SQL schema files to improve clarity. No public API declarations were altered. Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/javascripts/oxalis/shaders/utils.glsl.ts (1)
384-387: Refined Comment for Clarity in Large Interval ScalingThe comment on line 386 has been updated from "doing further arithmetics" to "doing further arithmetic." This minor editorial change improves the grammatical correctness and clarity of the code without impacting functionality.
tools/postgres/schema.sql (1)
357-367: Enhanced Spelling in Enum CommentsThe comments describing the transaction and credit states in the schema have been updated to fix misspellings (e.g., "committed" now appears where "commited" was previously used). These adjustments—such as in the descriptions for the "Complete," "Spent," and "Refunded" states—are purely editorial but enhance the overall readability and professionalism of the database schema documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.codespellrc(1 hunks)CHANGELOG.unreleased.md(1 hunks)build.sbt(1 hunks)frontend/javascripts/admin/api/jobs.ts(1 hunks)frontend/javascripts/oxalis/shaders/utils.glsl.ts(1 hunks)project/Dependencies.scala(3 hunks)project/build.properties(1 hunks)project/plugins.sbt(1 hunks)tools/postgres/schema.sql(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: circleci_build
🔇 Additional comments (18)
frontend/javascripts/admin/api/jobs.ts (1)
78-84: Editorial Correction in JobCreditCostInfo CommentThe comment for the
JobCreditCostInfotype now correctly uses "arithmetic" (instead of the previous "arithmetics") when describing that the front-end should not perform any arithmetic operations on the cost value. This refinement improves the documentation clarity.project/build.properties (1)
1-1: SBT version update looks good.This update from SBT 1.10.1 to 1.10.11 represents a minor version bump that likely includes bug fixes and performance improvements.
.codespellrc (2)
3-3: Skip pattern addition looks good.Adding the JSON files in the migration-unified-annotation-versioning directory to the skip list makes sense to avoid false positives in technical content.
6-6: Word addition to ignore list looks good.Adding 'DoubleClick' to the ignore-words-list is appropriate as it's a valid technical term in UI/UX contexts that might otherwise be flagged as a spelling error.
CHANGELOG.unreleased.md (1)
18-18: Changelog entry is appropriate.The added entry accurately documents the backend dependency upgrades and properly references the PR number, providing clear information for users about the improvements.
build.sbt (2)
4-4: Scala version update looks good.Updating from Scala 2.13.14 to 2.13.16 is a minor version bump that should maintain compatibility while providing bug fixes and improvements.
5-5:✅ Verification successful
Verify Scapegoat compatibility.
The update from Scapegoat 2.1.6 to 3.1.8 is a major version change that might introduce new static analysis rules or change existing ones.
🏁 Script executed:
#!/bin/bash # Check for any CI build logs that might show Scapegoat-related issues echo "Checking for any build logs with Scapegoat warnings or errors..." # Look for Scapegoat configuration to ensure it's compatible with the new version echo "Checking Scapegoat configuration..." rg -A 3 "scapegoat" --type scala rg "scapegoatDisabledInspections" --type sbt # Check if there are any mentions of Scapegoat in the project plugins echo "Checking Scapegoat plugin configuration..." cat project/plugins.sbt | grep -i scapegoatLength of output: 1428
Scapegoat Compatibility Verified
The Scapegoat upgrade to 3.1.8 in
build.sbtappears correctly integrated. The configuration (including settings likescapegoatDisabledInspectionsandscapegoatIgnoredFiles) remains in place, and the Scapegoat plugin inproject/plugins.sbtis still declared appropriately. Please double-check the 3.1.8 release notes to ensure that any newly introduced static analysis rules are adequately managed or explicitly disabled if needed.project/plugins.sbt (4)
2-2: LGTM - Play SBT plugin updated to 3.0.7This minor version update to the Play Framework SBT plugin (3.0.5 → 3.0.7) aligns with the corresponding Play dependency update in Dependencies.scala.
11-11: LGTM - Scalafmt plugin updatedThis patch version update (2.5.2 → 2.5.4) likely contains bug fixes and improvements.
14-14: LGTM - Scapegoat plugin updated to 1.2.12This update from version 1.2.4 to 1.2.12 likely includes multiple bug fixes and improvements.
5-5:✅ Verification successful
Verify compatibility with SBT Buildinfo 0.13.0
This update spans two minor versions (0.11.0 → 0.13.0), which could potentially include breaking changes or new configuration requirements.
🏁 Script executed:
#!/bin/bash # Check for any breaking changes or migration guides in the sbt-buildinfo releases echo "Checking for sbt-buildinfo release notes..." curl -s https://api.github.com/repos/sbt/sbt-buildinfo/releases | jq -r '.[] | select(.tag_name=="v0.13.0" or .tag_name=="v0.12.0") | {version: .tag_name, body: .body}'Length of output: 1689
SBT Buildinfo 0.13.0 Compatibility Verified
The release notes confirm that v0.13.0 mainly introduces a refactor to remove the deprecated
java.net.URLconstructor and adds cross-publishing support for both sbt 1.x and sbt 2.x (M2). There are no additional breaking changes or new configuration requirements for sbt 1.x users transitioning from earlier versions. If you are using sbt 2.x, please review the provided migration notes.project/Dependencies.scala (7)
6-6: LGTM - Brotli library updatedMinor version bump for the Brotli compression library from 1.16.0 to 1.17.0.
12-12: LGTM - Play Framework updated to 3.0.7This patch version update for Play aligns with the corresponding SBT plugin update in plugins.sbt.
18-18: LGTM - Commons IO updated to 2.17.0Minor version update for Apache Commons IO from 2.16.1 to 2.17.0.
61-61: Google Cloud Storage updated with successful verificationThis update spans three minor versions (2.40.1 → 2.43.1), but the PR description confirms that the functionality was tested: "Tested that we can still load a dataset from Google Cloud Storage".
65-65: LGTM - Commons Compress updated to 1.27.1Minor version update for Apache Commons Compress from 1.26.1 to 1.27.1.
101-107: LGTM - Slick and PostgreSQL libraries updatedGood practice to update all related Slick libraries (slick, slick-hikaricp, slick-codegen) to the same consistent version 3.5.2. The PostgreSQL driver is also updated to the latest patch version.
20-20:❓ Verification inconclusive
Verify Commons Lang3 compatibility with 3.17.0
This update spans two minor versions (3.15.0 → 3.17.0), which might include more significant changes.
🏁 Script executed:
#!/bin/bash # Check for breaking changes in commons-lang3 between versions 3.15.0 and 3.17.0 echo "Checking for Apache Commons Lang3 releases..." curl -s https://api.github.com/repos/apache/commons-lang/releases | jq -r '.[] | select(.tag_name=="rel/commons-lang-3.17.0" or .tag_name=="rel/commons-lang-3.16.0") | {version: .tag_name, body: .body}'Length of output: 305
Action: Confirm compatibility of Apache Commons Lang3 3.17.0
I ran the release note query for versions 3.16.0 and 3.17.0, which did not reveal any explicit breaking changes. However, since this update spans from 3.15.0 to 3.17.0, please ensure that your integration and regression tests cover any subtle differences in behavior. If your test suite passes without issues, the upgrade should be safe.
Some housekeeping
Steps to test: