Send right parameter to createNodeSkeletonAction

CHANGELOG.unreleased.md

@@ -43,6 +43,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - Removed unnecessary scrollbars in skeleton tab that occurred especially after resizing. [#8148](https://github.com/scalableminds/webknossos/pull/8148)
 - Deleting a bounding box is now possible independently of a visible segmentation layer. [#8164](https://github.com/scalableminds/webknossos/pull/8164)
 - S3-compliant object storages can now be accessed via HTTPS. [#8167](https://github.com/scalableminds/webknossos/pull/8167)
+- Fixed that skeleton tree nodes were created with the wrong mag. [#8185](https://github.com/scalableminds/webknossos/pull/8185)
 - Fixed a layout persistence bug leading to empty viewports, triggered when switching between orthogonal, flight, or oblique mode. [#8177](https://github.com/scalableminds/webknossos/pull/8177)
 
 ### Removed

frontend/javascripts/oxalis/model/helpers/nml_helpers.ts

@@ -412,7 +412,7 @@ function serializeNodes(
       rotY: node.rotation[1],
       rotZ: node.rotation[2],
       inVp: node.viewport,
-      inMag: node.mag,
+      inMag: node.resolution,
       bitDepth: node.bitDepth,
       interpolation: node.interpolation,
       time: node.timestamp,
@@ -963,7 +963,7 @@ export function parseNml(nmlString: string): Promise<{
               }),
               bitDepth: _parseInt(attr, "bitDepth", { defaultValue: DEFAULT_BITDEPTH }),
               viewport: _parseInt(attr, "inVp", { defaultValue: DEFAULT_VIEWPORT }),
-              mag: _parseInt(attr, "inMag", { defaultValue: DEFAULT_RESOLUTION }),
+              resolution: _parseInt(attr, "inMag", { defaultValue: DEFAULT_RESOLUTION }),
               radius: _parseFloat(attr, "radius", { defaultValue: Constants.DEFAULT_NODE_RADIUS }),
               timestamp: _parseTimestamp(attr, "time", { defaultValue: DEFAULT_TIMESTAMP }),
             };

frontend/javascripts/oxalis/model/reducers/skeletontracing_reducer_helpers.ts

@@ -146,7 +146,7 @@ export function createNode(
     radius,
     rotation,
     viewport,
-    mag: resolution,
+    resolution,
     id: nextNewId,
     timestamp,
     bitDepth: state.datasetConfiguration.fourBit ? 4 : 8,
@@ -846,7 +846,7 @@ function serverNodeToMutableNode(n: ServerNode): MutableNode {
     rotation: Utils.point3ToVector3(n.rotation),
     bitDepth: n.bitDepth,
     viewport: n.viewport,
-    mag: n.resolution,
+    resolution: n.resolution,
     radius: n.radius,
     timestamp: n.createdTimestamp,
     interpolation: n.interpolation,

frontend/javascripts/oxalis/model/sagas/proofread_saga.ts

@@ -270,7 +270,7 @@ function* createEditableMapping(): Saga<string> {
   // Get volume tracing again to make sure the version is up to date
   const upToDateVolumeTracing = yield* select((state) => getActiveSegmentationTracing(state));
   if (upToDateVolumeTracing == null) {
-    throw new Error("No active segmentation tracing layer. Cannot create editble mapping.");
+    throw new Error("No active segmentation tracing layer. Cannot create editable mapping.");
   }
 
   const volumeTracingId = upToDateVolumeTracing.tracingId;

frontend/javascripts/oxalis/store.ts

@@ -89,7 +89,7 @@ export type MutableNode = {
   rotation: Vector3;
   bitDepth: number;
   viewport: number;
-  mag: number;
+  resolution: number;
   radius: number;
   timestamp: number;
   interpolation: boolean;

frontend/javascripts/oxalis/view/right-border-tabs/connectome_tab/connectome_view.tsx

@@ -163,7 +163,7 @@ const synapseNodeCreator = (synapseId: number, synapsePosition: Vector3): Mutabl
   radius: Constants.DEFAULT_NODE_RADIUS,
   rotation: [0, 0, 0],
   viewport: 0,
-  mag: 0,
+  resolution: 0,
   id: synapseId,
   timestamp: Date.now(),
   bitDepth: 8,

frontend/javascripts/test/libs/nml.spec.ts

@@ -34,7 +34,7 @@ const createDummyNode = (id: number): Node => ({
   untransformedPosition: [id, id, id],
   additionalCoordinates: [],
   radius: id,
-  mag: 10,
+  resolution: 10,
   rotation: [id, id, id],
   timestamp: id,
   viewport: 1,

frontend/javascripts/test/reducers/skeletontracing_reducer.spec.ts

@@ -130,7 +130,7 @@ test("SkeletonTracing should add a new node", (t) => {
     untransformedPosition: position,
     rotation,
     viewport,
-    mag: resolution,
+    resolution,
     id: 1,
     radius: 1,
   });
@@ -295,7 +295,7 @@ test("SkeletonTracing should delete nodes and split the tree", (t) => {
     untransformedPosition: [0, 0, 0],
     additionalCoordinates: null,
     radius: 10,
-    mag: 10,
+    resolution: 10,
     rotation: [0, 0, 0],
     timestamp: 0,
     viewport: 1,
@@ -453,7 +453,7 @@ test("SkeletonTracing should delete an edge and split the tree", (t) => {
     untransformedPosition: [0, 0, 0],
     additionalCoordinates: null,
     radius: 10,
-    mag: 10,
+    resolution: 10,
     rotation: [0, 0, 0],
     timestamp: 0,
     viewport: 1,