Incorrect syntax highlighting with single quotes

[whoami730]

val x = ''' + '"'
val y = 1 + 0

is highlighted incorrectly and ''' is assumed to start a string instead of being the string itself whereas

val x = '"' + '''
val y = 1 + 0

is correctly highlighted

[som-snytt]

''' is bad syntax.

3 |  val x = ''' + '"'
  |          ^
  |          empty character literal (use '\'' for single quote)

[whoami730]

@som-snytt intellij seems to not be complaining - Guess I forgot to mention but this is scala 2.12.x

[whoami730]

https://scastie.scala-lang.org/ubVQfrgwSgyB3LWIa0x77A also seems to not complain

[som-snytt]

yes, it was a bug in 2.12. I remember the fix was deferred to a major release.

Actually github says 2.12.3. Oh wait, "Enforcement is under -Xsource:2.13." It was deprecated at 2.12.3, errors at 2.13.

https://scastie.scala-lang.org/2NAOmTP4SZeZHft2rRlYvQ

[nicolasstucki]

We should add a special rule to allow ''' as a character. It does not seem to conflict with 2.13 nor 3.x.

[som-snytt]

The caution is that people accustomed to other languages have various assumptions about quote marks, such as that they introduce strings.

If you allow this syntax, then you must explain that ''' is not analogous to """.

Since the need is rare, it's not burdensome to write '\''. When constructing a string, prefer s"so-called 'fun'!".

[whoami730]

i see @som-snytt thanks for the clarification - now that seems interesting and maybe we can swap usage of ''' to '\'' instead in our own codebase.