Fix #9977: Refine unrelated types criterion #9980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to take account of boxing.
liufengyun
reviewed
Oct 12, 2020
| val unrelated = | ||
| !testCls.derivesFrom(foundCls) | ||
| && !unboxedTestCls.derivesFrom(foundCls) | ||
| && (testCls.is(Final) || !testCls.is(Trait) && !foundCls.is(Trait)) |
There was a problem hiding this comment.
This line seems to change semantics of the original code:
Suggested change
| && (testCls.is(Final) || !testCls.is(Trait) && !foundCls.is(Trait)) | |
| && ((testCls.is(Final) || !testCls.is(Trait) && !foundCls.is(Trait))) |
There was a problem hiding this comment.
I don't think so. All the suggestion does is double the pair of outer parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to take account of boxing.