Skip to content

Fix #9213: handle valdefs in mixin parent constructors #9216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 22, 2020

No description provided.

@odersky odersky requested a review from sjrd June 22, 2020 10:49
@odersky odersky marked this pull request as ready for review June 22, 2020 10:49
@odersky
Copy link
Contributor Author

odersky commented Jun 22, 2020

@sjrd I am not sure this patch will still be required under the old/new mixin scheme. But the test case is important to have, and it's good to be aware of the issue.

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to still be necessary with the new scheme, as the test case fails on my branch, and merging the changes to Mixin with my branch fixes the test there as well.

@odersky odersky merged commit 4b3fdf6 into scala:master Jun 24, 2020
@odersky odersky deleted the fix-#9213 branch June 24, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trait with named parameters would lead to compiler error in specific cases
2 participants