Skip to content

Elide calls Printers.noPrinter.println #8610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2020
Merged

Elide calls Printers.noPrinter.println #8610

merged 2 commits into from
Mar 26, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 25, 2020 •
edited
Loading

Eliminates any explicit call to myPrinter.println if we know that myPrinter: noPrinter.type. This happens for all the printers defined in Printers.scala.

@nicolasstucki nicolasstucki self-assigned this Mar 25, 2020
@nicolasstucki nicolasstucki force-pushed the elide-noPrinter.println branch from 2237449 to a64a83f Compare March 26, 2020 06:05
@nicolasstucki nicolasstucki marked this pull request as ready for review March 26, 2020 06:45
liufengyun
liufengyun approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit d0bab30 into scala:master Mar 26, 2020
@nicolasstucki nicolasstucki deleted the elide-noPrinter.println branch March 26, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun