Skip to content

Elide assert message def binding if not used #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Elide assert message def binding if not used #8609

merged 1 commit into from
Mar 26, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 25, 2020 •
edited
Loading

This reduces slightly the size of the generated trees and elides some unnecessary closure creations.

@nicolasstucki nicolasstucki self-assigned this Mar 25, 2020
@nicolasstucki nicolasstucki force-pushed the optimize-DottyPredef-assert branch from 4a52b10 to a721b73 Compare March 25, 2020 16:10
@nicolasstucki nicolasstucki changed the title Elide message def binding if not used Elide assert message def binding if not used Mar 25, 2020
@nicolasstucki nicolasstucki force-pushed the optimize-DottyPredef-assert branch from a721b73 to d8a12d2 Compare March 25, 2020 16:40
@nicolasstucki
Elide assert message def binding if not used
f147b23 
This also reduces sligttly the size of the if it is used.
@nicolasstucki nicolasstucki force-pushed the optimize-DottyPredef-assert branch from d8a12d2 to f147b23 Compare March 26, 2020 06:02
@nicolasstucki nicolasstucki marked this pull request as ready for review March 26, 2020 06:39
liufengyun
liufengyun approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit fbd7228 into scala:master Mar 26, 2020
@nicolasstucki nicolasstucki deleted the optimize-DottyPredef-assert branch March 26, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun