Fix issue 8558 expose AlreadyLoaded via Reflection #8559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Mar 17, 2020
nicolasstucki
approved these changes
Mar 19, 2020
|
LGTM. But I may do some refactoring later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today ReadTasty (Tasty inspection) just emits a warning message to the console when you attempt to inspect a class that's already loaded, e.g. Option or Scala primitive. The message is not useful to the end-user and there's nothing pushed upstream to tell the caller that something unexpected happened. This fix implements a change that returns an AlreadyLoadedCompilationUnit from ReadTasty, which callers can either respond to or ignore--but at least they know something happened. This information is exposed via the Reflection API according to established pattern.
Fixes #8558