-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Favour error over implicit conversions with generic number literals #7468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
bishabosha
wants to merge
6
commits into
scala:master
from
bishabosha:numerics-suppress-implicit-conversions
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9067804
Favour error over implicit conversions with generic number literals
bishabosha 442c735
more friendly error messages for FromDigits summoners
bishabosha d57714d
alternative version using implicitNotFound
bishabosha 0a720d8
Update numeric literals documentation
bishabosha 181e450
fully document usage of FromDigits summoners.
bishabosha 4155cf2
more informative documentation of numeric-literals
bishabosha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update numeric literals documentation
- Loading branch information
commit 0a720d8d7009369c1dc7b10407cb1f1ad07b0ac6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is not enough. For instance, it is said that the companion object defines a method
fromDecimalDigits
but it is not specified where and when this method is called.I believe if we want to this to go ahead, it needs a complete rework of the doc page, and the SIP committee has to decide on the changes. My concern is that once the additions are fully worked in, we might decide that things became too complex.