Fix LazyRef#ref error recovery #7446
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `throw` keyword was missing, so the call to `CyclicReference` did not actually do anything. This means that LazyRef#ref could return null when typechecking broken code, which could lead to a NullPointerException (I observed this while compiling some code but didn't manage to minimize it).
odersky
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
throwkeyword was missing, so the call toCyclicReferencedidnot actually do anything. This means that LazyRef#ref could return null
when typechecking broken code, which could lead to a
NullPointerException (I observed this while compiling some code but
didn't manage to minimize it).