Skip to content

Rename implicit match to implied match #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

biboudis
Copy link
Contributor

@biboudis biboudis commented Jun 5, 2019

This PR introduces implied match as a rename for implicit match. Both are supported for now and doc's aren't updated to rename implicit -> implied.

In the next release (in 6 weeks) we plan to keep only the implied match syntax 😄

ping @milessabin

@biboudis biboudis force-pushed the rename-implicitmatch branch from 1b9d69f to ac05046 Compare June 6, 2019 14:56
@biboudis biboudis force-pushed the rename-implicitmatch branch from ac05046 to 6c6f3ce Compare June 6, 2019 15:05
@biboudis biboudis marked this pull request as ready for review June 6, 2019 15:05
@biboudis biboudis requested a review from odersky June 6, 2019 15:06
odersky
odersky previously requested changes Jun 7, 2019
@biboudis biboudis force-pushed the rename-implicitmatch branch from 7016997 to 5eccb61 Compare June 7, 2019 11:57
@biboudis biboudis dismissed odersky’s stale review June 7, 2019 11:58

Comments addressed

@biboudis biboudis requested a review from nicolasstucki June 7, 2019 12:00
@biboudis
Copy link
Contributor Author

biboudis commented Jun 7, 2019

Oops

@biboudis biboudis force-pushed the rename-implicitmatch branch from 5eccb61 to 27f9a47 Compare June 7, 2019 14:35
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@biboudis biboudis force-pushed the rename-implicitmatch branch from 27f9a47 to 8ccde0c Compare June 7, 2019 15:24
@biboudis biboudis merged commit edc16a1 into scala:master Jun 7, 2019
@biboudis biboudis deleted the rename-implicitmatch branch June 7, 2019 15:50
@biboudis biboudis added this to the 0.16 Tech Preview milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants