Port gestalt TypeToolbox #5388
Merged
Port gestalt TypeToolbox #5388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
port-gestalt-type-toolbox
branch
4 times, most recently
from
bea5f20 to
4685572
Compare
nicolasstucki
force-pushed
the
port-gestalt-type-toolbox
branch
from
4685572 to
0562c53
Compare
nicolasstucki
force-pushed
the
port-gestalt-type-toolbox
branch
from
0562c53 to
c5b986e
Compare
Contributor
Author
|
Rebased |
liufengyun
approved these changes
Nov 10, 2018
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
LGTM, much nicer than all the TypeTag hacks 👍
compiler/src/dotty/tools/dotc/tastyreflect/TypeOrBoundsTreesOpsImpl.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.