Back to the future: rewrite to inline
#5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a first step, rename all occurrences of `rewrite` to `inline`.
Analogous to `&` and `|`, treat `inline` as an identifier but intrepret it specially if it appears in places where it influences the syntax. This allows us to keep `@inline` as an annotation.
nicolasstucki
approved these changes
Sep 20, 2018
odersky
force-pushed
the
rewrite-to-inlined
branch
from
9b3dd87 to
c4f95f9
Compare
nicolasstucki
approved these changes
Sep 20, 2018
20 tasks
Contributor
|
|
Contributor
|
Was it doing it before? I thought we never added highlight for it. Now we should. |
Contributor
|
@nicolasstucki The inline keyword will be highlighted in Dotty 0.9.0-RC1. |
Contributor
|
Then I'll have a look at it. Thanks @Glavo. |
Contributor
|
@nicolasstucki This is fixed in #5137. Maybe you should review it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step, rename all occurrences of
rewritetoinline.inlineis now a soft keyword, so it can still be used as an annotation.