Reimplement LabelDefs using single transform #3362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had 3 transformations steps; the MiniPhaseTransformation and 2 TreeTransforms which retransformed the same label defs several times. With this change, all label defs transformations are performed the MiniPhaseTransformation. This is achieved by delaying the transformation of label defs until their first application is found.
nicolasstucki
force-pushed
the
fix-#2903
branch
from
03e7cda to
4987093
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had 3 transformations steps;
the MiniPhaseTransformation and 2 TreeTransforms which retransformed
the same label defs several times.
With this change, all label defs transformations are performed the
MiniPhaseTransformation. This is achieved by delaying the transformation
of label defs until their first application is found.