Fix Missing error message on FailureToEliminateExistential #3296
Conversation
| @@ -1778,4 +1778,15 @@ object messages { | |||
| hl"""A class marked with the ${"final"} keyword cannot be extended""" | |||
| } | |||
|
|
|||
| case class FailureToEliminateExistential(tp: Types.Type, tp1: Types.Type, tp2: Types.Type, boundSyms: List[Symbols.Symbol])(implicit ctx: Context) | |||
| extends Message(FailureToEliminateExistentialID) { | |||
| val kind = "Syntax" | |||
There was a problem hiding this comment.
This isn't a syntax related message. Maybe: Compatibility
| @@ -1778,4 +1778,15 @@ object messages { | |||
| hl"""A class marked with the ${"final"} keyword cannot be extended""" | |||
| } | |||
|
|
|||
| case class FailureToEliminateExistential(tp: Types.Type, tp1: Types.Type, tp2: Types.Type, boundSyms: List[Symbols.Symbol])(implicit ctx: Context) | |||
There was a problem hiding this comment.
Simply use Type instead of Types.Type and Symbol instead of Symbols.Symbol
| case class FailureToEliminateExistential(tp: Types.Type, tp1: Types.Type, tp2: Types.Type, boundSyms: List[Symbols.Symbol])(implicit ctx: Context) | ||
| extends Message(FailureToEliminateExistentialID) { | ||
| val kind = "Syntax" | ||
| val msg = hl"failure to eliminate existential" |
There was a problem hiding this comment.
hl"Failure to eliminate existential type. Proceed at own risk."
| hl"""original type : $tp forSome {${ctx.dclsText(boundSyms, "; ").show} | ||
| |reduces to : $tp1 | ||
| |type used instead: $tp2 | ||
| |proceed at own risk. |
There was a problem hiding this comment.
I think this is better as part of the msg
| val kind = "Syntax" | ||
| val msg = hl"failure to eliminate existential" | ||
| val explanation = | ||
| hl"""original type : $tp forSome {${ctx.dclsText(boundSyms, "; ").show} |
There was a problem hiding this comment.
I would extract original type in order to fully syntax highlight it:
val explanation = {
val originalTpe = s"$tp forSome {${ctx.dclsText(boundSyms, "; ").show}"
hl"""original type : $originalTpe
...
}
|
Thanks for code review @allanrenucci, i'll rebase and fix the issuses later this week |
CucumisSativus
force-pushed
the
failed_to_eliminate_existential
branch
from
64e1866 to
d7d4f21
Compare
|
Hey @allanrenucci can you lend me a hand with writing the test as such? I was moving through the documentation but I could find the documented case when such warning should appear. Any help with this would be very welcome |
|
@smarter I looked at our test suite and I can't find any test that exercises this warning. Could you give us an example? |
|
You'll need to compile some code with scalac (or find some existing code) that uses an existential type that cannot be expressed with wildcards, e.g. |
|
thanks @allanrenucci ! |
One step forward with #1589