Suggest runtimeChecked in warning/error messages #24672
Open
+177
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggest `.runtimeChecked` instead of `: @unchecked` also, change the patch applied under 3.2-migration.
bishabosha
added
the
backport:nominated
Member
Author
|
I dont remember if there is such a policy that migration patches are frozen (i.e. if the actual change should be a rewrite from in which case perhaps there can be 2 stages. The message mentions a patch applied under Edit: the second commit implements this by preserving behavior for pre-3.8 source mode. from 3.8 only the new message/patch is applied |
bishabosha
force-pushed
the
unchecked-to-runtimeChecked-warning-messages
branch
from
693e9e5 to
3770894
Compare
patch and warning message text will still suggest/replace `: @unchecked` pre 3.8. from 3.8-migration onwards, the message/patch suggests `.runtimeChecked` This preserves behavior under older source versions.
bishabosha
force-pushed
the
unchecked-to-runtimeChecked-warning-messages
branch
from
3770894 to
e944b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
runtimeCheckedwill be stable in 3.8.0, suggest.runtimeCheckedinstead of: @uncheckedalso, change the patch applied under 3.2-migration.Edit: pre 3.8, the warning and patch still suggest to use
: @unchecked. From 3.8 onwards the warning and patch will apply.runtimeCheckedinsteadfixes #23946