chore: StringContext methods are not Scala 2 macros anymore
#24407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Nov 13, 2025
Member
Author
There was a problem hiding this comment.
Purpose was to check that we can still call them even if they were considered Scala 2 macros. This is not the case anymore.
hamzaremmal
commented
Nov 13, 2025
| @@ -1,3 +0,0 @@ | |||
| class Foo extends StringContext { | |||
| override inline def f[A >: Any](args: A*): String = ??? // error | |||
Member
Author
There was a problem hiding this comment.
It is not a Scala 2 macro anymore, the test changed to use a custom Scala 2 Macro instead and be independent of the stdlib.
hamzaremmal
changed the title
StringContext methods are not macros Scala 2 macros anymoreStringContext methods are not Scala 2 macros anymore
hamzaremmal
added
the
backport:nominated
hamzaremmal
force-pushed
the
non-macro-interpolators
branch
from
a4cb81f to
31c77d5
Compare
Member
Author
|
blocked by sbt/sbt#8376 |
hamzaremmal
force-pushed
the
non-macro-interpolators
branch
from
31c77d5 to
654b1f5
Compare
hamzaremmal
commented
Dec 2, 2025
Comment on lines
+12
to
+14
| ProblemFilters.exclude[DirectMissingMethodProblem]("scala.StringContext.s"), | ||
| ProblemFilters.exclude[DirectMissingMethodProblem]("scala.StringContext.raw"), | ||
| ProblemFilters.exclude[DirectMissingMethodProblem]("scala.StringContext.f"), |
Member
Author
There was a problem hiding this comment.
This is fine since it will be backported to 3.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
s,fandrawinterpolators were considered Scala 2 macros in the past. This is now not the case and we define them as normal methods.For Scala 3.8.0, this will not be the case anymore. Those methods are normal methods and are a compiler intrinsic (as before).
Part of removing unnecessary special handling.