Skip to content

Fix crash in Selectable unapply with custom applyDynamic #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+14 −2
Merged

Fix crash in Selectable unapply with custom applyDynamic #24343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52bc468
Fix crash in Selectable unapply with custom applyDynamic
nox213 Nov 5, 2025
cf0a6b8
fix test
nox213 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/src/dotty/tools/dotc/typer/Dynamic.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ object DynamicUnapply {
def unapply(tree: tpd.Tree): Option[List[tpd.Tree]] = tree match
case TypeApply(Select(qual, name), _) if name == nme.asInstanceOfPM =>
unapply(qual)
case Apply(Apply(Select(selectable, fname), Literal(Constant(name)) :: ctag :: Nil), _ :: implicits)
case Apply(Apply(Select(selectable, fname), Literal(Constant(name)) :: restArgs), _ :: implicits)
if fname == nme.applyDynamic && (name == "unapply" || name == "unapplySeq") =>
Some(selectable :: ctag :: implicits)
Some(selectable :: (restArgs ::: implicits))
case _ =>
None
}
Expand Down
12 changes: 12 additions & 0 deletions tests/neg/i24168.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
trait Generic extends Selectable:
def applyDynamic(name: String)(args: Any*): Any = ()

val foo: Generic {
def unapply(x: Int): Option[Unit]
} = new Generic:
def unapply(x: Int): Option[Unit] = Some(())

def x =
42 match
case foo(()) => println("lol") // error

Loading