Skip to content

add selection ranges for more names #23257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

zielinsky
Copy link
Contributor

@zielinsky zielinsky commented May 23, 2025

Add selection ranges for more names.

Porting scalameta/metals#7446

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have some questions about some of the changes.

@zielinsky zielinsky requested a review from tgodzik May 30, 2025 12:28
@zielinsky zielinsky marked this pull request as ready for review May 30, 2025 12:49
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit dec859f into scala:main May 30, 2025
29 checks passed
@tgodzik tgodzik added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 30, 2025
tgodzik pushed a commit to scala/scala3-lts that referenced this pull request Jun 2, 2025
Add selection ranges for more names.

Porting scalameta/metals#7446
[Cherry-picked dec859f]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants