Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and future-proof the CI release scripts #21810

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Fix and future-proof the CI release scripts #21810

merged 2 commits into from
Oct 19, 2024

Conversation

WojciechMazur
Copy link
Contributor

  • Forward-ports changes to publish_release CI job from release-3.6.1 branch.
    • Fix building SDK archives, don't use build-sdk-packages job that produced artifacts in SNAPSHOT version
    • Fix typos introduced in template (forward port from release-3.6.0)
  • Detect and check version used to publish artifacts:
    • For release builds ensure that version is always matching tag used to trigger CI job
    • For nightly builds ensure that version is following the expected pattern
    • Tested in fork repository for positive and negative test case

@WojciechMazur WojciechMazur merged commit 34f1c54 into scala:main Oct 19, 2024
28 checks passed
@WojciechMazur WojciechMazur deleted the ci/fix-releasing branch October 19, 2024 18:04
@hamzaremmal hamzaremmal mentioned this pull request Oct 20, 2024
Merged
WojciechMazur pushed a commit that referenced this pull request Oct 20, 2024
@hamzaremmal
Use bash shell when using here-strings (#21817)
022b1ff 
<img width="1032" alt="Screenshot 2024-10-20 at 07 14 49"
src="https://github.com/user-attachments/assets/321ba7ce-9fd2-413c-aec3-14215fbee786">


[positive](https://github.com/WojciechMazur/dotty/actions/runs/11416876799/job/31768568868)
test in #21810 also uses `bash` instead of `sh`

Closes #21815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @hamzaremmal