Skip to content

Fix failing CompletionScalaCliSuite tests due to circe releasing Scala Native 0.5 artifacts #20931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamzaremmal merged 2 commits into from
Jul 2, 2024
Merged

Fix failing CompletionScalaCliSuite tests due to circe releasing Scala Native 0.5 artifacts #20931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0f1ce
Fix failing CompletionScalaCliSuite tests due to circe releasing Scal…
WojciechMazur Jul 1, 2024
c60699e
Ignore failing tests instead of expecting for completions for both 0.…
WojciechMazur Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix failing CompletionScalaCliSuite tests due to circe releasing Scal… 
…a Native 0.5 artifacts
  • Loading branch information
@WojciechMazur
WojciechMazur committed Jul 1, 2024
commit fa0f1ce0c1131ba185c68c464a5cfee24f4c63bb
16 changes: 13 additions & 3 deletions presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionScalaCliSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:
|// //> using lib ???
|//> using lib io.circe::circe-core_native0.4
|package A
|""".stripMargin
|""".stripMargin,
assertSingleItem = false
)

@Test def `version-sort` =
Expand All @@ -51,6 +52,9 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:
"""|circe-core_native0.4_2.12
|circe-core_native0.4_2.13
|circe-core_native0.4_3
|circe-core_native0.5_2.12
|circe-core_native0.5_2.13
|circe-core_native0.5_3
|""".stripMargin
)

Expand Down Expand Up @@ -78,7 +82,9 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:
"""|//> using lib "io.circe::circe-core:0.14.0", "io.circe::circe-core_na@@"
|package A
|""".stripMargin,
"circe-core_native0.4"
"""circe-core_native0.4
|circe-core_native0.5
|""".stripMargin
)

@Test def `script` =
Expand All @@ -92,6 +98,9 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:
"""|circe-core_native0.4_2.12
|circe-core_native0.4_2.13
|circe-core_native0.4_3
|circe-core_native0.5_2.12
|circe-core_native0.5_2.13
|circe-core_native0.5_3
|""".stripMargin,
filename = "script.sc.scala",
enablePackageWrap = false
Expand Down Expand Up @@ -138,7 +147,8 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:
"""|//> using libs "io.circe::circe-core:0.14.0", "io.circe::circe-core_na@@"
|package A
|""".stripMargin,
"circe-core_native0.4"
"""circe-core_native0.4
|circe-core_native0.5""".stripMargin
)

private def scriptWrapper(code: String, filename: String): String =
Expand Down