Skip to content

Make CheckUnused not slow. #20321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2024
Merged

Make CheckUnused not slow. #20321

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
69664f7
Make `unusedDataApply` inline so that no closure is allocated.
sjrd May 2, 2024
0bd4b15
Do not use `LazyList` in `CheckUnused`.
sjrd May 2, 2024
6d79caa
Do not mangle names only to test whether it starts with a given string.
sjrd May 2, 2024
3188177
Remove dead code `newCtx` in `CheckUnused`.
sjrd May 2, 2024
a55ee4d
Do not use Sets of Trees in `CheckUnused`.
sjrd May 2, 2024
701d69f
Remove a useless sort and otherwise sort by offset, not line.
sjrd May 2, 2024
803dff7
Refactor unused imports to try and make sense of it.
sjrd May 3, 2024
0c1f090
Fix some indentation.
sjrd May 3, 2024
975df4a
Simplify the logic for checking unused imports.
sjrd May 3, 2024
8553bfc
Move the isAccessible test up to registerSym, instead of isInImport.
sjrd May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make unusedDataApply inline so that no closure is allocated. 
It is used for every single tree in `CheckUnused`, so this is worth
it.
  • Loading branch information
@sjrd
sjrd committed May 6, 2024
commit 69664f7c01e0103cc02ee5fae9d63ad04abe46d7
6 changes: 4 additions & 2 deletions compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ class CheckUnused private (phaseMode: CheckUnused.PhaseMode, suffix: String, _ke
import CheckUnused.*
import UnusedData.*

private def unusedDataApply[U](f: UnusedData => U)(using Context): Context =
ctx.property(_key).foreach(f)
private inline def unusedDataApply[U](inline f: UnusedData => U)(using Context): Context =
ctx.property(_key) match
case Some(ud) => f(ud)
case None => ()
ctx

override def phaseName: String = CheckUnused.phaseNamePrefix + suffix
Expand Down