Better error diagnostics under -explain-cyclic #20251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also report type-checked right hand sides and export expansions. Streamline trace-handling code using inline functions. Fixes scala#20245
mbovel
approved these changes
Apr 25, 2024
| ctx.property(CyclicReference.Trace).isDefined | ||
|
|
||
| def pushTrace(info: TraceElement)(using Context): Unit = | ||
| private def pushTrace(info: Context ?=> String)(using Context): Unit = |
Member
There was a problem hiding this comment.
Couldn't the type of info stay `TraceElement?
odersky
commented
Apr 25, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jul 6, 2024
) Backports #20251 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also report type-checked right hand sides and export expansions.
Streamline trace-handling code using inline functions.
Fixes #20245