Only cache base types when gadt state is empty #19562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19562/ to see the changes. Benchmarks is based on merging with main (b20747d) |
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/19562/ to see the changes. Benchmarks is based on merging with main (b20747d) |
Contributor
Author
|
It looks like simply not caching base types when the |
EugeneFlesselle
force-pushed
the
issues/i19521
branch
from
bd25160 to
0a759cc
Compare
EugeneFlesselle
changed the title
dwijnand
approved these changes
Jan 30, 2024
Member
dwijnand
left a comment
dwijnand
left a comment
There was a problem hiding this comment.
Feels reasonable, on balance.
WojciechMazur
added a commit
that referenced
this pull request
Jul 1, 2024
) Backports #19562 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Typerinserts casts for trees which only conform using gadt constraints, so that -Ycheck succeeds in later phases.We recheck in an empty GadtState, whether the type is found to already be a subtype, in which case we do not add the cast. The issue is that
isSubtyperelies on the baseType cache, which might have been populated in a ctx with the narrowing gadt constraints.https://github.com/lampepfl/dotty/blob/1716bcd9dbefbef88def848c09768a698b6b9ed9/compiler/src/dotty/tools/dotc/typer/Typer.scala#L4075-L4084
Fixes #19521