Skip to content

Conversation

@julienrf
Copy link
Contributor

Relates to #15111

@julienrf julienrf requested review from ckipp01 and smarter May 17, 2023 14:22
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW, I tend to agree with what you said in #15111:

I keep thinking that all the content related to external contributions should be in docs.scala-lang.org/contribute

But it seems like there's been more discussion since then I wasn't a part of, and it's not a big deal either way I think.

@julienrf julienrf requested a review from ckipp01 May 19, 2023 07:44
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienrf julienrf enabled auto-merge May 19, 2023 08:23
@julienrf julienrf merged commit 005b3e5 into scala:main May 19, 2023
@ckipp01 ckipp01 deleted the dotty-website branch May 19, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants