Skip to content

Backport "WUnused: Fix for symbols with synthetic names and unused transparent inlines" #17250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Backport "WUnused: Fix for symbols with synthetic names and unused transparent inlines" #17250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f85c64
Fix #16822
PaulCoral Feb 15, 2023
609bc59
Traverse annotations instead of just registering
PaulCoral Feb 18, 2023
557640e
WUnused: Fix unused warnining in synthetic symbols
szymon-rd Feb 27, 2023
b009fd5
Move tests
szymon-rd Feb 28, 2023
5abf61f
Remove unused import
szymon-rd Feb 28, 2023
efa502a
WUnused: Fix for symbols with synthetic names and unused transparent …
szymon-rd Mar 7, 2023
3969ba9
Adjust assertions in test
szymon-rd Mar 8, 2023
4cdc72f
Check if import contains transparent inline in registerImport
szymon-rd Mar 10, 2023
0da834e
Warn for synthetic using/givens with wunused
szymon-rd Mar 28, 2023
87e3510
Wunused: only filter out non-zero span-length givens
szymon-rd Mar 28, 2023
e8e5656
Skip all symbols with $ in name in Wunused
szymon-rd Mar 29, 2023
fd49eb6
Add a failing case with named using to test Wunused:implicits
szymon-rd Mar 29, 2023
b3c6071
Replace for with exists in isTransparentInline in WUNused
szymon-rd Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check if import contains transparent inline in registerImport
  • Loading branch information
@szymon-rd @Kordyjan
szymon-rd authored and Kordyjan committed Apr 14, 2023
commit 4cdc72fa16577de340b33657409dcfd08d0a51a1
29 changes: 14 additions & 15 deletions compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import dotty.tools.dotc.core.Decorators.{em, i}
import dotty.tools.dotc.core.Flags.*
import dotty.tools.dotc.core.Phases.Phase
import dotty.tools.dotc.core.StdNames
import dotty.tools.dotc.{ast, report}
import dotty.tools.dotc.report
import dotty.tools.dotc.reporting.Message
import dotty.tools.dotc.typer.ImportInfo
import dotty.tools.dotc.util.{Property, SrcPos}
Expand Down Expand Up @@ -360,7 +360,7 @@ object CheckUnused:

/** Register an import */
def registerImport(imp: tpd.Import)(using Context): Unit =
if !tpd.languageImport(imp.expr).nonEmpty && !imp.isGeneratedByEnum then
if !tpd.languageImport(imp.expr).nonEmpty && !imp.isGeneratedByEnum && !isTransparentAndInline(imp) then
impInScope.top += imp
unusedImport ++= imp.selectors.filter { s =>
!shouldSelectorBeReported(imp, s) && !isImportExclusion(s)
Expand Down Expand Up @@ -426,19 +426,6 @@ object CheckUnused:
exists
}

// not report unused transparent inline imports
for {
imp <- imports
sel <- imp.selectors
} {
if unusedImport.contains(sel) then
val tpd.Import(qual, _) = imp
val importedMembers = qual.tpe.member(sel.name).alternatives.map(_.symbol)
val isTransparentAndInline = importedMembers.exists(s => s.is(Transparent) && s.is(Inline))
if isTransparentAndInline then
unusedImport -= sel
}

// if there's an outer scope
if usedInScope.nonEmpty then
// we keep the symbols not referencing an import in this scope
Expand Down Expand Up @@ -513,6 +500,18 @@ object CheckUnused:
end getUnused
//============================ HELPERS ====================================


/**
* Checks if import selects a def that is transparent and inline
*/
private def isTransparentAndInline(imp: tpd.Import)(using Context): Boolean =
(for {
sel <- imp.selectors
} yield {
val qual = imp.expr
val importedMembers = qual.tpe.member(sel.name).alternatives.map(_.symbol)
importedMembers.exists(s => s.is(Transparent) && s.is(Inline))
}).exists(identity)
/**
* Heuristic to detect synthetic suffixes in names of symbols
*/
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-custom-args/fatal-warnings/i15503f.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ val default_int = 1

def f1(a: Int) = a // OK
def f2(a: Int) = 1 // OK
def f3(a: Int)(using Int) = a // error
def f3(a: Int)(using Int) = a // OK
def f4(a: Int)(using Int) = default_int // error
def f6(a: Int)(using Int) = summon[Int] // OK
def f7(a: Int)(using Int) = summon[Int] + a // OK
Expand Down
4 changes: 2 additions & 2 deletions tests/neg-custom-args/fatal-warnings/i15503g.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ val default_int = 1

def f1(a: Int) = a // OK
def f2(a: Int) = default_int // error
def f3(a: Int)(using Int) = a // error
def f4(a: Int)(using Int) = default_int // error // error
def f3(a: Int)(using Int) = a // OK
def f4(a: Int)(using Int) = default_int // error
def f6(a: Int)(using Int) = summon[Int] // error
def f7(a: Int)(using Int) = summon[Int] + a // OK

Expand Down