Skip to content

Make CheckUnused run both after Typer and Inlining #17206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2023
Merged

Make CheckUnused run both after Typer and Inlining #17206

merged 6 commits into from
Apr 13, 2023

Conversation

@szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Apr 4, 2023 •
edited
Loading

Resolve #16876

@Kordyjan Kordyjan added this to the 3.3.0 backports milestone Apr 12, 2023
@Kordyjan Kordyjan added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 12, 2023
@szymon-rd szymon-rd force-pushed the checkunused-after-inlining-and-typer branch from ff3febf to fa07b41 Compare April 13, 2023 13:02
Kordyjan
Kordyjan requested changes Apr 13, 2023
View reviewed changes
@szymon-rd szymon-rd force-pushed the checkunused-after-inlining-and-typer branch from 2023103 to 3f67e27 Compare April 13, 2023 13:59
@Kordyjan Kordyjan enabled auto-merge April 13, 2023 14:08
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Apr 13, 2023
@Kordyjan Kordyjan merged commit 45fb481 into scala:main Apr 13, 2023
@Kordyjan Kordyjan mentioned this pull request Apr 14, 2023
Merged
Kordyjan added a commit that referenced this pull request Apr 17, 2023
@Kordyjan
Backport "Make CheckUnused run both after Typer and Inlining" (#17279)
c043299 
Backports #17206
@Kordyjan Kordyjan added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Apr 17, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

-Wunused reporting should wait until macro expansion for analysis

2 participants

@szymon-rd @Kordyjan