Skip to content

Fix WUnused with idents in derived code #17095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2023
Merged

Fix WUnused with idents in derived code #17095

merged 4 commits into from
Mar 15, 2023

Conversation

@szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Mar 13, 2023

Resolve #16679

@szymon-rd szymon-rd force-pushed the fix/wunused-idents-derived branch from af2fda3 to 0aa99f8 Compare March 13, 2023 14:16
@szymon-rd szymon-rd force-pushed the fix/wunused-idents-derived branch 2 times, most recently from cd36837 to 67ca2fe Compare March 13, 2023 14:38
@szymon-rd szymon-rd requested a review from Kordyjan March 13, 2023 14:45
@szymon-rd szymon-rd force-pushed the fix/wunused-idents-derived branch from 67ca2fe to 7f5aa62 Compare March 13, 2023 14:46
@szymon-rd szymon-rd changed the title Fix WUnused with indents in derived code Fix WUnused with idents in derived code Mar 13, 2023
@Kordyjan Kordyjan enabled auto-merge March 14, 2023 16:43
@Kordyjan Kordyjan merged commit 9d51be0 into scala:main Mar 15, 2023
@Kordyjan Kordyjan mentioned this pull request Mar 15, 2023
Closed
@Kordyjan Kordyjan added this to the 3.3.0 backports milestone Apr 12, 2023
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Apr 12, 2023
This was referenced Apr 13, 2023
Closed
Merged
Kordyjan added a commit that referenced this pull request Apr 17, 2023
@Kordyjan
Backport "Fix WUnused with idents in derived code " (#17273)
1615cd2 
Backports #17095
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Apr 17, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 1, 2023
@som-snytt som-snytt mentioned this pull request Mar 8, 2025
Merged
sjrd added a commit that referenced this pull request Mar 10, 2025
@sjrd
Restore resolving prefixes of implicit Ident (#22751)
a59d3e1 
Fixes #22744 

This code was originally for derived, but is also needed for implicits
(where private objects are in the path).

#17095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

Assignees

@Kordyjan Kordyjan

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

-Wunused:all and nested type class derivation

2 participants

@szymon-rd @Kordyjan