Skip to content

WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 30, 2023
Merged

WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4219db2
WUnused: Fix for symbols with synthetic names and unused transparent …
szymon-rd Mar 7, 2023
c36965c
Adjust assertions in test
szymon-rd Mar 8, 2023
8ff4754
Check if import contains transparent inline in registerImport
szymon-rd Mar 10, 2023
56b484d
Warn for synthetic using/givens with wunused
szymon-rd Mar 28, 2023
00b3d25
Wunused: only filter out non-zero span-length givens
szymon-rd Mar 28, 2023
e9077a9
Skip all symbols with $ in name in Wunused
szymon-rd Mar 29, 2023
a83d0c9
Add a failing case with named using to test Wunused:implicits
szymon-rd Mar 29, 2023
1f9e869
Replace for with exists in isTransparentInline in WUNused
szymon-rd Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust assertions in test
  • Loading branch information
@szymon-rd
szymon-rd committed Mar 28, 2023
commit c36965ce94ff81e18e88294d932a3d9014668f70
4 changes: 2 additions & 2 deletions tests/neg-custom-args/fatal-warnings/i15503-scala2/scala2-t11681.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ trait Anonymous {
trait Context[A]
trait Implicits {
def f[A](implicit ctx: Context[A]) = answer // error
def g[A: Context] = answer // error
def g[A: Context] = answer // OK
}
class Bound[A: Context] // error
class Bound[A: Context] // OK
object Answers {
def answer: Int = 42
}
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-custom-args/fatal-warnings/i15503b.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ package foo.scala2.tests:

object Types {
def l1() = {
object HiObject { def f = this } // error
object HiObject { def f = this } // OK
class Hi { // error
def f1: Hi = new Hi
def f2(x: Hi) = x
Expand Down