Skip to content

Some performance related changes #16566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jan 20, 2023
Merged

Some performance related changes #16566

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
de04a7d
Better benchmark and Stats infrastructure
odersky Jan 5, 2023
7e0c815
Reduce allocations for pickling
odersky Jan 5, 2023
cb40386
Reduce context creations for value class related ops
odersky Jan 5, 2023
2fbb891
Refactor context pools
odersky Jan 5, 2023
3d21427
Avoid creation of Type lists when assigning types to Apply nodes
odersky Dec 20, 2022
47f5b02
Pickling reorganizations
odersky Jan 5, 2023
8dee679
Reduce string computations
odersky Dec 22, 2022
ac95795
Avoid recomputing hot requiredMethods
odersky Dec 22, 2022
7036ed8
Don't have Diagnostic inherit from Exception
odersky Jan 5, 2023
f8e7f78
Reuse regex matcher in replaceAll calls
odersky Jan 5, 2023
e0e703a
Add specialized versions of tasty.Util.dble for common array element …
odersky Dec 22, 2022
c9a4670
Allow to reuse table of a util.{MutableHashSet,MutableHashMap}
odersky Jan 5, 2023
e459eda
Avoid some Some wrappers when accessing maps
odersky Dec 22, 2022
10359a5
Avoid unnecessary uses of `parentSyms`
odersky Dec 22, 2022
03555e8
Avoid some boxings of vars
odersky Jan 5, 2023
4e7ab60
Avoid creating large CharBuffers in LookaheadScanners
odersky Dec 22, 2022
50c1595
Avoid expensive settings lookup in `setDenot`
odersky Dec 23, 2022
9f13e56
Make `validFor` monomorphic
odersky Dec 23, 2022
84c4fe0
Cache `isType` in SymDenotations
odersky Jan 5, 2023
b28faf9
Streamline some hot compuations
odersky Jan 5, 2023
f992f7a
Inline rollbackGadtUnless in GadtConstraint
odersky Jan 5, 2023
c920896
Replace tpd.mapInline by flattenMapConserve
odersky Dec 25, 2022
bc8df3e
Optimize period equality tests
odersky Dec 25, 2022
b64b73c
Drop expensive escapeToNext
odersky Jan 5, 2023
88c84ea
Use home-brewed futures for parallel pickling
odersky Dec 26, 2022
78f1be0
Drop redundant catch and re-throw
odersky Jan 5, 2023
586c459
Revert some changes in NameBuffer
odersky Jan 5, 2023
f2caf05
Make lazy vals threadunsafe.
odersky Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop redundant catch and re-throw
  • Loading branch information
@odersky
odersky committed Jan 20, 2023
commit 78f1be0853e4b98bbfe85cc687b7f53dcdbe5f69
3 changes: 0 additions & 3 deletions compiler/src/dotty/tools/dotc/core/Denotations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,6 @@ object Denotations {
// creations that way, and also avoid phase caches in contexts to get large.
// To work correctly, we need to demand that the context with the new phase
// is not retained in the result.
catch case ex: CyclicReference =>
// println(s"error while transforming $this")
throw ex
finally
mutCtx.setPeriod(savedPeriod)
if next eq cur then
Expand Down