Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap compiler with -Ysafe-init #15722

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Bootstrap compiler with -Ysafe-init #15722

merged 8 commits into from
Aug 3, 2022

Conversation

liufengyun
Copy link
Contributor

Bootstrap compiler with -Ysafe-init

@liufengyun
Copy link
Contributor Author

test performance with #projects please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/15722/ to see the changes.

Benchmarks is based on merging with main (1b299b3)

@liufengyun liufengyun requested a review from olhotak July 26, 2022 22:50
@liufengyun liufengyun marked this pull request as ready for review July 26, 2022 23:41
olhotak
olhotak approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This LGTM. Was there an important reason for the stat:do-not-merge label?

@liufengyun
Copy link
Contributor Author

Was there an important reason for the stat:do-not-merge label?

I am not sure whether we should enable -Ysafe-init in benchmarks. To avoid variance, maybe we can remove it.

@liufengyun liufengyun merged commit 08ad92e into scala:main Aug 3, 2022
@liufengyun liufengyun deleted the init-bootstrap branch August 3, 2022 14:28
@Kordyjan Kordyjan added this to the 3.2.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@liufengyun @dottybot @olhotak @Kordyjan