Skip to content

Add enum companion reflection to scala.reflect #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
wip
  • Loading branch information
soronpo committed Dec 18, 2021
commit 05fb25da98a414def2ee0d374e8b006ff7a7614c
6 changes: 5 additions & 1 deletion compiler/src/dotty/tools/dotc/ast/Desugar.scala
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,11 @@ object desugar {

companionDefs(anyRef, applyMeths ::: unapplyMeth :: toStringMeth :: companionMembers)
}
else if (companionMembers.nonEmpty || companionDerived.nonEmpty || isEnum)
else if (isEnum)
val r = ref(defn.EnumCompanionClass.typeRef)
val r2 = appliedTypeTree(r, ref(requiredClass(className).typeRef) :: Nil)
companionDefs(r2, companionMembers)
else if (companionMembers.nonEmpty || companionDerived.nonEmpty)
companionDefs(anyRef, companionMembers)
else if (isValueClass)
companionDefs(anyRef, Nil)
Expand Down
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/core/Definitions.scala
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ class Definitions {

@tu lazy val EnumClass: ClassSymbol = requiredClass("scala.reflect.Enum")
@tu lazy val Enum_ordinal: Symbol = EnumClass.requiredMethod(nme.ordinal)
@tu lazy val EnumCompanionClass: ClassSymbol = requiredClass("scala.reflect.EnumCompanion")

@tu lazy val EnumValueSerializationProxyClass: ClassSymbol = requiredClass("scala.runtime.EnumValueSerializationProxy")
@tu lazy val EnumValueSerializationProxyConstructor: TermSymbol =
Expand Down
8 changes: 8 additions & 0 deletions library/src/scala/reflect/Enum.scala
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,11 @@ package scala.reflect

/** A number uniquely identifying a case of an enum */
def ordinal: Int

//@annotation.transparentTrait trait EnumCompanion extends AnyRef

/** A base trait of all Scala enum companion definitions */
@annotation.transparentTrait trait EnumCompanion[E <: Enum] extends AnyRef:

def values : Array[E]
def valueOf(name : String) : E
2 changes: 1 addition & 1 deletion tests/init/neg/enum-desugared.scala
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sealed abstract class ErrorMessageID($name: String, _$ordinal: Int)
def errorNumber: Int = this.ordinal() - 2
}

object ErrorMessageID {
object ErrorMessageID extends scala.reflect.EnumCompanion[ErrorMessageID]{

final val LazyErrorId = $new(0, "LazyErrorId")
final val NoExplanationID = $new(1, "NoExplanationID")
Expand Down
7 changes: 4 additions & 3 deletions tests/pos/enum-companion-first.scala
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
object Planet:
final val G = 6.67300E-11
final val G = 6.67300E-11

enum Planet(mass: Double, radius: Double) extends Enum[Planet]:
def surfaceGravity = Planet.G * mass / (radius * radius)
def surfaceGravity = G * mass / (radius * radius)
def surfaceWeight(otherMass: Double) = otherMass * surfaceGravity

case Mercury extends Planet(3.303e+23, 2.4397e6)
case Venus extends Planet(4.869e+24, 6.0518e6)

val check = summon[Planet.type <:< scala.reflect.EnumCompanion[Planet]]