Clarify that using val is given member #12312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
May 3, 2021
|
|
||
| class GivenIntBox2(using givenInt: Int): | ||
| given Int = givenInt | ||
| //def n = summon[Int] // ambiguous |
Contributor
There was a problem hiding this comment.
Thanks for the explanation! Maybe we can use given Int = 42 here? Otherwise one might argue that semantically there is no ambiguity -- only the compiler complains about it.
Contributor
Author
There was a problem hiding this comment.
Interesting point. My idea was that if you want to "export givenInt" as a given, you might try it this way.
b-studios
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10882