Drop old given syntax #10613
Merged
Drop old given syntax #10613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Dec 2, 2020
Comment on lines
+249
to
252
| given PackageClauseTypeTest: TypeTest[Tree, PackageClause] = PackageClauseTypeTestImpl | ||
|
|
||
| /** Implementation of `PackageClauseTypeTest` */ | ||
| protected val PackageClauseTypeTestImpl: TypeTest[Tree, PackageClause] |
There was a problem hiding this comment.
Looks like you could directly use abstract givens for this now:
Suggested change
| given PackageClauseTypeTest: TypeTest[Tree, PackageClause] = PackageClauseTypeTestImpl | |
| /** Implementation of `PackageClauseTypeTest` */ | |
| protected val PackageClauseTypeTestImpl: TypeTest[Tree, PackageClause] | |
| given PackageClauseTypeTest: TypeTest[Tree, PackageClause] |
There was a problem hiding this comment.
Is that supported now?
nicolasstucki
approved these changes
Dec 3, 2020
|
@odersky I merged the current version to avoid conflicts with other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10598