Add missing owner for ValDef.let
#10402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Nov 20, 2020
| @@ -2673,6 +2674,9 @@ trait QuoteContext { self: internal.QuoteUnpickler & internal.QuoteMatching => | |||
|
|
|||
| trait SymbolModule { this: Symbol.type => | |||
|
|
|||
| /** Owner definition of the current splice */ | |||
| def spliceOwner: Symbol | |||
|
|
|||
There was a problem hiding this comment.
Minor: what about currentOwner? I find spliceOwner is not so easy to understand.
There was a problem hiding this comment.
The current owner will eventually need to disappear if we use an explicit owner scheme. spliceOwner is the ower of the current splice (i.e. x in val x = ${ ... }; ...). This is the same as the owner of the current QuoteContext. But currentOwner would be a confusing name to use for this one as in the middle of a TreeMap the current owner is not the same as the owner of the QuoteContext.
nicolasstucki
force-pushed
the
add-missing-owner-to-ValDef.let
branch
from
92929be to
dc03cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix of the missing owner of
ValDef.letwith explicit owners. Alternative with contextual owners in #10394.