Skip to content

Fix #9533: handle nested TypeParamRef in bounds #10109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2020
Merged

Fix #9533: handle nested TypeParamRef in bounds #10109

merged 3 commits into from
Oct 30, 2020

Conversation

liufengyun
Copy link
Contributor

Fix #9533: handle nested TypeParamRef in bounds

abgruszecki
abgruszecki reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct solution, thanks for fixing the issue! I originally had a TypeMap in a similar place to where you put it and Martin was concerned about performance, so I think we should ensure that there's no regression. Otherwise LGTM.

@abgruszecki
Copy link
Contributor

abgruszecki commented Oct 28, 2020 •
edited by liufengyun
Loading

test performance please

1 similar comment
@liufengyun
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10109/ to see the changes.

Benchmarks is based on merging with master (6a73701)

@smarter smarter added this to the 3.0.0-M1 milestone Oct 30, 2020
@liufengyun liufengyun merged commit c0ff503 into scala:master Oct 30, 2020
@liufengyun liufengyun deleted the fix-9533 branch October 30, 2020 12:24
@Kordyjan Kordyjan modified the milestones: 3.0.0-M1, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgruszecki abgruszecki abgruszecki left review comments

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

AssertionError when typechecking a match with variance
5 participants
@liufengyun @abgruszecki @dottybot @smarter @Kordyjan