Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation with JDK 11 failed due to changes in the Java String API #5463

Closed
Glavo opened this issue Nov 19, 2018 · 0 comments
Closed

Compilation with JDK 11 failed due to changes in the Java String API #5463

Glavo opened this issue Nov 19, 2018 · 0 comments

Comments

@Glavo
Copy link
Contributor

Glavo commented Nov 19, 2018

The String#lines method has been added to the Java 11 String, this change causes Dotty to fail to compile:

[error] /home/glavo/Dotty/dotty/compiler/src/dotty/tools/dotc/util/ParsedComment.scala:151:44: value mkString is not a member of java.util.stream.Stream[String]
[error]     val formattedItems = items.map(_.lines.mkString(System.lineSeparator + "   "))
[error]                                            ^
[error] one error found
[error] (dotty-compiler / Compile / compileIncremental) Compilation failed
[error] Total time: 29 s, completed 2018年11月19日 下午5:35:12
Glavo added a commit to Glavo/dotty that referenced this issue Nov 19, 2018
@Glavo
Fix scala#5463: Replace the call to the String#lines method
59c49fa
@Glavo Glavo mentioned this issue Nov 19, 2018
Merged
Glavo added a commit to Glavo/dotty that referenced this issue Nov 19, 2018
@Glavo
Fix scala#5463: Replace the call to the String#lines method
b894420
allanrenucci added a commit that referenced this issue Nov 19, 2018
@allanrenucci
Merge pull request #5464 from Glavo/master
0a1aed2 
Fix #5463: Replace the call to the String#lines method
@michelou michelou mentioned this issue Feb 27, 2019
Merged
allanrenucci added a commit that referenced this issue Feb 27, 2019
@allanrenucci
Merge pull request #5993 from michelou/string-api
dbe94b3 
Follow-up of issue #5463 (String API change in JDK 11)
@villazon villazon mentioned this issue May 8, 2019
Closed
@cgrigis cgrigis mentioned this issue Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Glavo