Nightly build failed (in macro-expansion-dependencies-2 sbt scripted test)

[griggt]

The nightly build failed on the macro-expansion-dependencies-2 scripted test in test_sbt:

-Error: [error] -- [E006] Not Found Error: /tmp/sbt_41e7727c/macro-expansion-dependencies-2/MacroRuntime.scala:7:6 
-Error: [error] 7 |      error("some error", rootPosition)
-Error: [error]   |      ^^^^^
-Error: [error]   |      Not found: error
-Error: [error] -- [E006] Not Found Error: /tmp/sbt_41e7727c/macro-expansion-dependencies-2/MacroRuntime.scala:7:26 
-Error: [error] 7 |      error("some error", rootPosition)
-Error: [error]   |                          ^^^^^^^^^^^^
-Error: [error]   |                          Not found: rootPosition
-Error: [error] two errors found
-Error: [error] (Compile / compileIncremental) Compilation failed
-Error: [error] Total time: 1 s, completed Nov 24, 2020 4:29:10 AM
 [info] [success] Total time: 0 s, completed Nov 24, 2020 4:29:11 AM
 [info] [info] Compiling 3 Scala sources to /tmp/sbt_41e7727c/macro-expansion-dependencies-2/target/scala-3.0.0-M2/classes ...
 [info] [info] Done compiling.
 [info] [success] Total time: 1 s, completed Nov 24, 2020 4:29:11 AM
 [info] [info] Compiling 1 Scala source to /tmp/sbt_41e7727c/macro-expansion-dependencies-2/target/scala-3.0.0-M2/classes ...
 [info] [info] Done compiling.
 [info] [info] running Main 
 [info] Implementation in Macro
 [info] [success] Total time: 0 s, completed Nov 24, 2020 4:29:12 AM
-Error:  x source-dependencies / macro-expansion-dependencies-2 
-Error:   Cause of test exception: {line 13}  Command succeeded but failure was expected

It looks like macro-expansion-dependencies-1 could use an update as well:

https://github.com/lampepfl/dotty/blob/64c8e77aa9bb0e9e928ecd0609b85eb3b47f8c69/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-1/changes/MacroCompileError.scala#L9

Note: the actual cause of the job failure is that the runtime test of MacroRuntimeRuntimeError.scala on line 13 succeeded when it was expected to fail. The "not found" errors don't cause the job to fail because they are inside tests that are expected to fail at compile time.

EDIT: It seems the failure is for some reason caused by the recent change making the context parameter anonymous:

https://github.com/lampepfl/dotty/blob/64c8e77aa9bb0e9e928ecd0609b85eb3b47f8c69/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-2/changes/MacroRuntimeRuntimeError.scala#L5

[griggt]

This test failed in the nightly build again. Perhaps an update was missed in #10474?

[info] [info] compiling 2 Scala sources to /tmp/sbt_89516e3b/target/scala-3.0.0-RC1/classes ...
[info] [error] -- [E006] Not Found Error: /tmp/sbt_89516e3b/MacroRuntime.scala:7:6 ------------
[info] [error] 7 |      Reporting.error("some error", Position.ofMacroExpansion)
[info] [error]   |      ^^^^^^^^^
[info] [error]   |      Not found: Reporting
[info] [error] one error found
[info] [error] (Compile / compileIncremental) Compilation failed
[info] [error] Total time: 0 s, completed Nov 27, 2020 4:15:21 AM
Error:  x source-dependencies/macro-expansion-dependencies-2 
Error:   Cause of test exception: {line 3}  Command failed: compile failed

[nicolasstucki]

It conflicted with another PR. I'll take care of it.