Address feedback.

Author: q-ata

compiler/src/dotty/tools/dotc/transform/init/Semantic.scala

@@ -67,7 +67,7 @@ object Semantic:
         "the original object of type (" + klass.show + ") where initialization checking started"
       case Warm(klass, outer, ctor, args) =>
         val argsText = if args.nonEmpty then ", args = " + args.map(_.show).mkString("(", ", ", ")") else ""
-        "an initialized (Warm) object of type (" + klass.show + ") { outer = " + outer.show + argsText + " }"
+        "a non-transitively initialized (Warm) object of type (" + klass.show + ") { outer = " + outer.show + argsText + " }"
       case Fun(expr, thisV, klass) =>
         "a function where \"this\" is (" + thisV.show + ") and the function owner is an object of type (" + klass.show + ")"
       case RefSet(values) =>
@@ -472,7 +472,7 @@ object Semantic:
     def widenArg: Contextual[Value] =
       a match
       case _: Ref | _: Fun =>
-        val hasError = Reporter.hasErrors { a.promote("Argument cannot be proven to be transitively initialized (Hot)") }
+        val hasError = Reporter.hasErrors { a.promote("Argument is not provably transitively initialized (Hot)") }
         if hasError then Cold else Hot
 
       case RefSet(refs) =>
@@ -710,7 +710,7 @@ object Semantic:
               promoteArgs()
               // try promoting the receiver as last resort
               val hasErrors = Reporter.hasErrors {
-                ref.promote(ref.show + " has no source code and could not be proven to be transitively initialized (Hot).")
+                ref.promote(ref.show + " has no source code and is not provably transitively initialized (Hot).")
               }
               if hasErrors then
                 val error = CallUnknown(target)(trace)

tests/init/neg/inherit-non-hot.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/inherit-non-hot.scala:6:32 --------------------------------------------------------------------
 6 |            if b == null then b = new B(this) // error
   |                              ^^^^^^^^^^^^^^^
-  |The RHS of reassignment must be transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = a transitively initialized (Hot) object, args = (an uninitialized (Cold) object) }.  Calling trace:
+  |The RHS of reassignment must be transitively initialized (Hot). It was found to be a non-transitively initialized (Warm) object of type (class B) { outer = a transitively initialized (Hot) object, args = (an uninitialized (Cold) object) }.  Calling trace:
   |-> class C extends A {	[ inherit-non-hot.scala:15 ]
   |   ^
   |-> val bAgain = toB.getBAgain	[ inherit-non-hot.scala:16 ]

tests/init/neg/promotion-loop.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/promotion-loop.scala:16:10 --------------------------------------------------------------------
 16 |  println(b)      // error
    |          ^
-   |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = the original object of type (class Test) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+   |Could not verify that the method argument is transitively initialized (Hot). It was found to be a non-transitively initialized (Warm) object of type (class B) { outer = the original object of type (class Test) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
    |-> class Test { test =>	[ promotion-loop.scala:1 ]
    |   ^
    |-> println(b)      // error	[ promotion-loop.scala:16 ]

tests/init/neg/promotion-segment3.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/promotion-segment3.scala:9:6 ------------------------------------------------------------------
 9 |  bar(new B)  // error
   |      ^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = the original object of type (class A) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be a non-transitively initialized (Warm) object of type (class B) { outer = the original object of type (class A) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
   |-> class A:	[ promotion-segment3.scala:2 ]
   |   ^
   |-> bar(new B)  // error	[ promotion-segment3.scala:9 ]