Add parentheses to make warnings more clear

Author: q-ata

compiler/src/dotty/tools/dotc/transform/init/Semantic.scala

@@ -64,12 +64,12 @@ object Semantic:
   sealed abstract class Value:
     def show(using Context): String = this match
       case ThisRef(klass) =>
-        "the original object of type \"" + klass.show + "\" where initialization checking started"
+        "the original object of type (" + klass.show + ") where initialization checking started"
       case Warm(klass, outer, ctor, args) =>
         val argsText = if args.nonEmpty then ", args = " + args.map(_.show).mkString("(", ", ", ")") else ""
-        "an initialized (Warm) object of type " + klass.show + "{ outer = " + outer.show + argsText + " }"
+        "an initialized (Warm) object of type (" + klass.show + ") { outer = " + outer.show + argsText + " }"
       case Fun(expr, thisV, klass) =>
-        "a function where \"this\" is " + thisV.show + " and the function owner is an object of type " + klass.show
+        "a function where \"this\" is (" + thisV.show + ") and the function owner is an object of type (" + klass.show + ")"
       case RefSet(values) =>
         values.map(_.show).mkString("Set { ", ", ", " }")
       case Hot =>

tests/init/neg/closureLeak.check

@@ -1,14 +1,14 @@
 -- Error: tests/init/neg/closureLeak.scala:11:14 -----------------------------------------------------------------------
 11 |    l.foreach(a => a.addX(this)) // error
    |              ^^^^^^^^^^^^^^^^^
-   |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is the original object of type "class Outer" where initialization checking started and the function owner is an object of type class Outer. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+   |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is (the original object of type (class Outer) where initialization checking started) and the function owner is an object of type (class Outer). Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
    |-> class Outer {	[ closureLeak.scala:1 ]
    |   ^
    |-> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
    |             ^^^^^^^^^^^^^^^^^
    |
    |Promoting the value to transitively initialized (Hot) failed due to the following problem:
-   |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class Outer" where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
+   |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type (class Outer) where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
    |Non initialized field(s): value p. Promotion trace:
    |-> l.foreach(a => a.addX(this)) // error	[ closureLeak.scala:11 ]
    |                         ^^^^

tests/init/neg/default-this.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/default-this.scala:9:8 ------------------------------------------------------------------------
 9 |        compare() // error
   |        ^^^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class B" where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type (class B) where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
   |Non initialized field(s): value result. Calling trace:
   |-> class B extends A {	[ default-this.scala:6 ]
   |   ^

tests/init/neg/i15459.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/i15459.scala:3:10 -----------------------------------------------------------------------------
 3 |  println(this)  // error
   |          ^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class Sub" where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type (class Sub) where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
   |Non initialized field(s): value b. Calling trace:
   |-> class Sub extends Sup:	[ i15459.scala:5 ]
   |   ^

tests/init/neg/inherit-non-hot.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/inherit-non-hot.scala:6:32 --------------------------------------------------------------------
 6 |            if b == null then b = new B(this) // error
   |                              ^^^^^^^^^^^^^^^
-  |The RHS of reassignment must be transitively initialized (Hot). It was found to be an initialized (Warm) object of type class B{ outer = a transitively initialized (Hot) object, args = (an uninitialized (Cold) object) }.  Calling trace:
+  |The RHS of reassignment must be transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = a transitively initialized (Hot) object, args = (an uninitialized (Cold) object) }.  Calling trace:
   |-> class C extends A {	[ inherit-non-hot.scala:15 ]
   |   ^
   |-> val bAgain = toB.getBAgain	[ inherit-non-hot.scala:16 ]

tests/init/neg/inlined-method.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/inlined-method.scala:8:45 ---------------------------------------------------------------------
 8 |    scala.runtime.Scala3RunTime.assertFailed(message) // error
   |                                             ^^^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class InlineError" where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type (class InlineError) where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
   |Non initialized field(s): value v. Calling trace:
   |-> class InlineError {	[ inlined-method.scala:1 ]
   |   ^

tests/init/neg/inner-first.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/inner-first.scala:3:12 ------------------------------------------------------------------------
 3 |    println(this)           // error
   |            ^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class B" where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type (class B) where initialization checking started. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region.
   |Non initialized field(s): value n. Calling trace:
   |-> class B:	[ inner-first.scala:2 ]
   |   ^

tests/init/neg/promotion-loop.check

@@ -1,14 +1,14 @@
 -- Error: tests/init/neg/promotion-loop.scala:16:10 --------------------------------------------------------------------
 16 |  println(b)      // error
    |          ^
-   |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type class B{ outer = the original object of type "class Test" where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+   |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = the original object of type (class Test) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
    |-> class Test { test =>	[ promotion-loop.scala:1 ]
    |   ^
    |-> println(b)      // error	[ promotion-loop.scala:16 ]
    |           ^
    |
    |Promoting the value to transitively initialized (Hot) failed due to the following problem:
-   |Could not verify that the field value outer is transitively initialized (Hot). It was found to be the original object of type "class Test" where initialization checking started.
+   |Could not verify that the field value outer is transitively initialized (Hot). It was found to be the original object of type (class Test) where initialization checking started.
    |Non initialized field(s): value n. Promotion trace:
    |-> val outer = test	[ promotion-loop.scala:12 ]
    |   ^^^^^^^^^^^^^^^^

tests/init/neg/promotion-segment3.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/promotion-segment3.scala:9:6 ------------------------------------------------------------------
 9 |  bar(new B)  // error
   |      ^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type class B{ outer = the original object of type "class A" where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be an initialized (Warm) object of type (class B) { outer = the original object of type (class A) where initialization checking started }. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
   |-> class A:	[ promotion-segment3.scala:2 ]
   |   ^
   |-> bar(new B)  // error	[ promotion-segment3.scala:9 ]

tests/init/neg/t3273.check

@@ -1,7 +1,7 @@
 -- Error: tests/init/neg/t3273.scala:4:42 ------------------------------------------------------------------------------
 4 |  val num1: LazyList[Int] = 1 #:: num1.map(_ + 1)                        // error
   |                                  ^^^^^^^^^^^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is the original object of type "object Test" where initialization checking started and the function owner is an object of type object Test. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is (the original object of type (object Test) where initialization checking started) and the function owner is an object of type (object Test). Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
   |-> object Test {	[ t3273.scala:3 ]
   |   ^
   |-> val num1: LazyList[Int] = 1 #:: num1.map(_ + 1)                        // error	[ t3273.scala:4 ]
@@ -14,7 +14,7 @@
 -- Error: tests/init/neg/t3273.scala:5:61 ------------------------------------------------------------------------------
 5 |  val num2: LazyList[Int] = 1 #:: num2.iterator.map(_ + 1).to(LazyList)  // error
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is the original object of type "object Test" where initialization checking started and the function owner is an object of type object Test. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
+  |Could not verify that the method argument is transitively initialized (Hot). It was found to be a function where "this" is (the original object of type (object Test) where initialization checking started) and the function owner is an object of type (object Test). Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. Calling trace:
   |-> object Test {	[ t3273.scala:3 ]
   |   ^
   |-> val num2: LazyList[Int] = 1 #:: num2.iterator.map(_ + 1).to(LazyList)  // error	[ t3273.scala:5 ]