Skip to content

fix: ensure everything works and instructions updated #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jul 9, 2022

This pr makes a couple changes.

  • Updates the README to be more inline with the one in https://github.com/scala/scala3-example-project
  • Updates mill to the latest and adds in a .mill-version file
  • Fixes the build - closes Build error #13
  • Makes the structure a bit more "mill like" instead of using the
    SbtModule (opinionated, but will be more what you actually see in
    the wild as I've never personally seen SbtModule used)
  • Gets rid of random sbt files like build.sbt and project/

This pr makes a couple changes.
  - Updates the README to be more inline with the one in https://github.com/scala/scala3-example-project
  - Updates mill to the latest and adds in a .mill-version file
  - Fixes the build - closes scala#13
  - Makes the structure a bit more "mill like" instead of using the
    SbtModule (opinionated, but will be more what you actually see in
    the wild as I've never personally seen SbtModule used)
  - Gets rid of random sbt files like build.sbt and project/
  - updated the stuff in the workflow to use coursier cache action
Copy link
Contributor

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@SethTisue
Copy link
Member

review by @anatoliykmetyuk, perhaps?

@anatoliykmetyuk anatoliykmetyuk merged commit 0c8c57f into scala:main Jul 15, 2022
@ckipp01 ckipp01 deleted the fix branch July 15, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error
4 participants