Skip to content

Fix #72 XMLEventReader does not handle ' properly #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2017
Merged

Fix #72 XMLEventReader does not handle ' properly #89

merged 2 commits into from
May 24, 2017

Conversation

ashawley
Copy link
Member

@ashawley ashawley commented Dec 15, 2015 •
edited
Loading 

Fix #72 XMLEventReader does not handle ' properly

* jvm/src/main/scala/scala/xml/Utility.scala: Uncomment apos in
unescape map.

* jvm/src/test/scala/scala/xml/pull/XMLEventReaderTest.scala (entityRefTest):
Unit test from Fehmi Can Saglam <fehmican.saglam@gmail.com>

@lespea lespea mentioned this pull request Apr 21, 2016
Closed
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch 4 times, most recently from f911ac5 to ecef265 Compare June 13, 2016 14:23
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch 2 times, most recently from 79588dd to a67af81 Compare September 20, 2016 22:09
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from a67af81 to 6f1e6f3 Compare October 18, 2016 15:45
@SethTisue
Copy link
Member

this seems like a good candidate for inclusion in 1.0.7

@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from 6f1e6f3 to 3f67bd2 Compare December 1, 2016 21:03
@SethTisue
Copy link
Member

needs rebase now

is there anyone watching this repo who can review this for Aaron...?

@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from 3f67bd2 to 3abc033 Compare February 4, 2017 19:15
@SethTisue
Copy link
Member

are this and #85 duplicates?

@SethTisue SethTisue mentioned this pull request Feb 5, 2017
Closed
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch 3 times, most recently from 4ac3474 to f0a8b4e Compare February 6, 2017 15:29
@ashawley
Copy link
Member Author

ashawley commented Feb 6, 2017

This patch had been more general and produced &apos; more often in output as was discussed in #72, but I've updated it to be a more limited fix.

@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from f0a8b4e to 38c56ca Compare February 7, 2017 22:21
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from 38c56ca to 85f2587 Compare February 15, 2017 23:53
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch 4 times, most recently from b6a09da to f218f7c Compare April 28, 2017 14:15
@ashawley
Copy link
Member Author

Well, I guess it wasn't that "limited": MiMa is suddenly raising a bincompat issue related to Utility.pairs, that hadn't been raised before, so that's cool. The new MiMa 0.1.12 is great. Looks like it was the inner classes improvements that were made in MiMa.

@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch 3 times, most recently from 51b3cfc to 159d7da Compare May 5, 2017 15:59
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from 159d7da to a024c3a Compare May 6, 2017 14:31
@ashawley
Fix scala#72 XMLEventReader does not handle &apos; properly
3b0775b 
	* shared/src/main/scala/scala/xml/Utility.scala: Uncomment
	apos in unescape map.

	* jvm/src/test/scala/scala/xml/pull/XMLEventReaderTest.scala
	(entityRefTest): Refactor unit test.
@ashawley ashawley force-pushed the fix-72-xmleventreader-apos branch from a024c3a to 3b0775b Compare May 12, 2017 10:14
@ashawley ashawley merged commit 9ed63c4 into scala:master May 24, 2017
@ashawley ashawley deleted the fix-72-xmleventreader-apos branch May 24, 2017 15:50
@ashawley ashawley mentioned this pull request Oct 9, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashawley @SethTisue @fehmicansaglam