Skip to content

Conversation

@dacr
Copy link
Contributor

@dacr dacr commented Feb 23, 2014

...se/SI-4267

  • small changes in .gitignore to ignore lock files temporary generated by vi or vim
  • add (if you don't mind) the sbteclipse plugin
  • And the most important, merge enhancements done by Guillem Salas
    https://issues.scala-lang.org/browse/SI-4267

@gkossakowski
Copy link
Contributor

Thanks for contribution! The failure in Travis seems to be unrelated to your change and is probably problem on our end. We'll look into in a few days.

.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go in your local git excludes file, as it's specific to your setup, not this project

@adriaanm
Copy link
Contributor

Thanks for your contribution, @dacr! Please take a look at https://github.com/scala/scala/wiki/Pull-Request-Policy for commit message formatting. Please also sign the cla at: http://typesafe.com/contribute/cla/scala

@dacr
Copy link
Contributor Author

dacr commented Feb 24, 2014

I've signed the CLA and thanks for your advices. You're right about the Throwable exception, it is not a good practice and I do not need it.

I will modify the pull request, and provide the test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants