Replace partest neg tests with JUnit tests. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the ToolBox compiler. Minor cheat required:
must add header `import scala.xml.{TopScope => $scope}`,
which is normally added (synthetically) by the compiler.
Somehow, the toolbox compiler doesn't see this change to `rootContext`.
This adds a dependency on scala-compiler (for the toolbox compiler),
and on JUnit, but removes the dependency on partest.
CompilerErrors defines a class CompilerTesting that we might factor out.
It's based on https://github.com/scala/async/blob/master/src/test/scala/scala/async/package.scala#L34
|
lgtm |
retronym
added a commit
that referenced
this pull request
Nov 19, 2013
Replace partest neg tests with JUnit tests.
|
@adriaanm Good question. Looks like a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ToolBox compiler. Minor cheat required:
must add header
import scala.xml.{TopScope => $scope},which is normally added (synthetically) by the compiler.
Somehow, the toolbox compiler doesn't see this change to
rootContext./cc @xeno-by, any idea why?
This adds a dependency on scala-compiler (for the toolbox compiler),
and on JUnit, but removes the dependency on partest.
CompilerErrors defines a class CompilerTesting that we might factor out.
It's based on https://github.com/scala/async/blob/master/src/test/scala/scala/async/package.scala#L34
review by @retronym