Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserveWhitespace not used in Utility.serialize? #185

Open
olafos opened this issue Jan 31, 2018 · 3 comments
Open

preserveWhitespace not used in Utility.serialize? #185

olafos opened this issue Jan 31, 2018 · 3 comments
Labels
good first issue

Comments

@olafos
Copy link
Contributor

olafos commented Jan 31, 2018

I'm wondering what is the expected result of serializing node using Utility.serialize with preserveWhitespace = false. I've analyzed the code and can't see it used anywhere.
@ashawley
Copy link
Member

Yeah, it was added in 31b4fe1 and e18538b but seems it was a library-wide change that was aspirational but never completed.

@timzaak
Copy link

timzaak commented Dec 28, 2018

is there any new plan about this issue?

@ashawley
Copy link
Member

I presume it's a change that could be made, but I haven't looked in to it. Things often look easier to do than they are, but anyone is welcome to investigate and see if it could be fixed. We'd be willing to review the fix and see if it can be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashawley @olafos @timzaak