Skip to content

issue #242 implementation of repNM for 1.2.x #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2019
Merged

issue #242 implementation of repNM for 1.2.x #245

merged 3 commits into from
Nov 19, 2019

Conversation

@pgrandjean
Copy link
Contributor

No description provided.

@pgrandjean pgrandjean changed the title issue #242 implementation of repMN issue #242 implementation of repMN for 1.2.x Oct 16, 2019
@pgrandjean
Copy link
Contributor Author

I have signed the Scala CLA.

@SethTisue SethTisue requested a review from Philippus October 25, 2019 14:35
Philippus
Philippus requested changes Oct 25, 2019
View reviewed changes
Philippus
Philippus reviewed Oct 25, 2019
View reviewed changes
@SethTisue
Copy link
Member

fwiw, https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html uses the "n, m" ordering (not "m, n")

@SethTisue
Copy link
Member

I guess the parameters need names, but baking the NM/MN thing into the name of the trait (repMN) isn't necessary, I think? if we have repN, then the other one ought to be repNM, I think, not repMN. but perhaps we could dodge the issue (except in the parameter names) with a name like repRange... or something?

pgrandjean added a commit to pgrandjean/scala-parser-combinators that referenced this pull request Oct 27, 2019
@pgrandjean
code review PR scala#245
34f752a
@pgrandjean
Copy link
Contributor Author

@SethTisue I like repNM, it's pretty compact and intuitive if you know regex.

@pgrandjean pgrandjean requested a review from Philippus October 27, 2019 00:34
@pgrandjean pgrandjean changed the title issue #242 implementation of repMN for 1.2.x issue #242 implementation of repNM for 1.2.x Oct 31, 2019
SethTisue
SethTisue reviewed Nov 6, 2019
View reviewed changes
@SethTisue
Copy link
Member

SethTisue commented Nov 14, 2019 •
edited
Loading

this seems ready for merge once Travis-CI likes it; I think it's failing currently because this fix is needed: scala/scala#8536 — @pgrandjean could you add a commit that makes that change?

@lrytz
Copy link
Member

lrytz commented Nov 18, 2019

Cleared the travis caches and re-started the build, it's green now.

@SethTisue SethTisue merged commit 4d64b03 into scala:1.2.x Nov 19, 2019
@pgrandjean
Copy link
Contributor Author

@SethTisue @Philippus @lrytz thank you!

@pgrandjean pgrandjean deleted the issue_242_1.2.x branch November 19, 2019 15:59
@pgrandjean pgrandjean mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SethTisue SethTisue SethTisue left review comments

@Philippus Philippus Philippus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgrandjean @SethTisue @lrytz @Philippus