2.13: scala-dist-smoketest started failing recently

[SethTisue]

e.g. https://travis-ci.org/scala/scala-dist-smoketest/builds/393890841

last thing in the log is some fsc stuff, maybe fsc related? it's been failing for a while now, not months, just weeks I think? finding the last green / first red commits might make the cause obvious?

[martijnhoekstra]

the smoke test turned from green to red after scala/scala#6747

[SethTisue]

@som-snytt is it a scala regression or does scala-dist-smoketest itself just need to be updated?

[som-snytt]

I'll take a look. I'll have to take a longer look.

I always get WFM and WTF mixed up. It's just running fsc and looking for "shutdown" in the output. It doesn't -shutdown the CompileServer.

+ testCommand fsc shutdown
++ /Users/andrew/workspace/scala/build/pack/bin/fsc
++ grep shutdown
+ output='  -shutdown                      Shutdown compile server'
+ [[   -shutdown                      Shutdown compile server =~ .*shutdown.* ]]
+ testCommand scaladoc doc-title
++ /Users/andrew/workspace/scala/build/pack/bin/scaladoc
++ grep doc-title
+ output='  -doc-title <title>                          The overall name of the Scaladoc site'
+ [[   -doc-title <title>                          The overall name of the Scaladoc site =~ .*doc-title.* ]]

I grabbed a sample failing bundle. For some reason, wget isn't on Mac OS, then brew had to update.
Anyway, same result:

$ ./st
++ pwd
+ bin=/Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin
+ echo /Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin
/Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin
+ testCommand scalac classpath
++ /Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin/scalac
++ grep classpath
+ output='  -bootclasspath <path>                Override location of bootstrap class files.
  -classpath <path>                    Specify where to find user class files.
  -javabootclasspath <path>            Override java boot classpath.
  -javaextdirs <path>                  Override java extdirs classpath.
  -nobootcp                            Do not use the boot classpath for the scala jars.
  -toolcp <path>                       Add to the runner classpath.
  -usejavacp                           Utilize the java.class.path in classpath resolution.
  -usemanifestcp                       Utilize the manifest in classpath resolution.'
+ [[   -bootclasspath <path>                Override location of bootstrap class files.
  -classpath <path>                    Specify where to find user class files.
  -javabootclasspath <path>            Override java boot classpath.
  -javaextdirs <path>                  Override java extdirs classpath.
  -nobootcp                            Do not use the boot classpath for the scala jars.
  -toolcp <path>                       Add to the runner classpath.
  -usejavacp                           Utilize the java.class.path in classpath resolution.
  -usemanifestcp                       Utilize the manifest in classpath resolution. =~ .*classpath.* ]]
+ testCommand fsc shutdown
++ /Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin/fsc
++ grep shutdown
+ output='  -shutdown                      Shutdown compile server'
+ [[   -shutdown                      Shutdown compile server =~ .*shutdown.* ]]
+ testCommand scaladoc doc-title
++ /Users/andrew/tmp/scala-2.13.0-pre-211bc44/bin/scaladoc
++ grep doc-title
+ output='  -doc-title <title>                          The overall name of the Scaladoc site'
+ [[   -doc-title <title>                          The overall name of the Scaladoc site =~ .*doc-title.* ]]

Never mind, it was because the CompileClient runs whatever scala command is on the PATH? I can reproduce after snipping my PATH. So that's probably a bug, too.

[som-snytt]

For the record, the smoketest didn't fail. It was working perfectly. And I think it wasn't weeks but about five days. It only feels like weeks.

[som-snytt]

That was pretty painful. I hope it lets the smokey smoke test clear.

[SethTisue]

thanks Som!

[som-snytt]

Also thx @martijnhoekstra for noticing the change.