Get our test suite working on Java 11 and 16

[retronym]

Here's the current state of running our test suite of Java 9:

https://gist.github.com/retronym/65527edfa7dcb4a4e905f364db9788d3

That's based on sbt testAll on the tip of scala/scala#6733.

I expect the majority of failures will just requires some changes to the test themselves.

Getting these working will let us include Java 9/10 in our CI.

[som-snytt]

✋

[som-snytt]

I finally got started on this. I needed an excuse to use Java 10...

[SethTisue]

Getting these working will let us include Java 9/10 in our CI.

should be very easy in Travis-CI. would be harder in Jenkins.

[som-snytt]

test issue might be the pun we've been looking for on seth tisue.

[SethTisue]

@som-snytt can't hear you, too busy watching “Good Times” re-runs

[retronym]

I've fixed the OSGi tests in scala/scala#6937

After scala/scala#6889, I'm down to two failed partests:

# starting 1 test in run
Note: test execution will be non-parallel under -Dpartest.exec.in.process
!! 1 - run/t6146b.scala                          [output differs][duration 9.20s]
% diff /Users/jz/code/scala/test/files/run/t6146b.check /Users/jz/code/scala/test/files/run/t6146b-run.log
@@ -14,19 +14,30 @@ import u._
 import language._

 scala> val S1 = typeOf[c.X.S1.type forSome { val c: C[_] }].typeSymbol.tpeHK
-S1: u.Type = C.X.S1.type
+                                                    ^
+       error: C does not take type parameters

 scala> val S2 = typeOf[O.S2].typeSymbol.tpeHK
-S2: u.Type = C.this.S2
+                         ^
+       error: type S2 is not a member of object O

 scala> val S3 = typeOf[O.S3].typeSymbol.tpeHK
-S3: u.Type = O.S3
+                       ^
+       error: Symbol 'type C.F' is missing from the classpath.
+       This symbol is required by 'class O.S3'.
+       Make sure that type F is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
+       A full rebuild may help if 'O.class' was compiled against an incompatible version of C.

 scala> val S4 = typeOf[S4].typeSymbol.tpeHK
-S4: u.Type = S4
+                       ^
+       error: Symbol 'type C.F' is missing from the classpath.
+       This symbol is required by 'class S4'.
+       Make sure that type F is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
+       A full rebuild may help if 'S4.class' was compiled against an incompatible version of C.

 scala> val F = typeOf[c.F[_] forSome { val c: C[_] }].typeSymbol.tpeHK
-F: u.Type = C.this.F
+                                              ^
+       error: C does not take type parameters

 scala> val fTpe = typeOf[O.type].decl(newTermName("foo")).paramss.head.head.tpe
 fTpe: u.Type = O.F[Int]
@@ -38,22 +49,25 @@ memType: (sub: u.Type, scrut: u.Type)u.Type
 scala>

 scala> val mt1 = memType(S1, fTpe)
-mt1: u.Type = O.X.S1.type
+                         ^
+       error: not found: value S1

 scala> global.typeDeconstruct.show(mt1)
-res0: String =
-TypeRef(
-  pre = SingleType(pre = ThisType(object O), object X)
-  TypeSymbol(class S1 extends C.this.F[T])
-)
+                                   ^
+       error: not found: value mt1

 scala> memType(S2, fTpe)
-res1: u.Type = O.S2
+               ^
+       error: not found: value S2

 scala> memType(S3, fTpe)
-res2: u.Type = O.S3
+               ^
+       error: not found: value S3

 scala> memType(S4, fTpe)
-res3: u.Type = S4
+               ^
+       error: type mismatch;
+        found   : S4.type (with underlying type <notype>)
+        required: u.Type

 scala> :quit

# 0/1 passed, 1 failed in run

# starting 1 test in jvm
!! 1 - jvm/javaReflection                        [output differs]
% diff /Users/jz/code/scala/test/files/jvm/javaReflection.check /Users/jz/code/scala/test/files/jvm/javaReflection-jvm.log
@@ -20,218 +20,185 @@ A / A (canon) / A (simple)
 - declared cls: List(class A$B, interface A$C, class A$D$)
 - enclosing   : null (declaring cls) / null (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? false
 A$$anon$2 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$2 is anonymous
 assert not class A$$anon$2
 A$$anon$3 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$3 is anonymous
 assert not class A$$anon$3
 A$$anon$4 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$4 is anonymous
 assert not class A$$anon$4
 A$$anon$5 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$5 is anonymous
 assert not class A$$anon$5
 A$$anon$6 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$6 is anonymous
 assert not class A$$anon$6
 A$$anon$7 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / public A(int) (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$$anon$7 is anonymous
 assert not class A$$anon$7
 A$B / A.B (canon) / B (simple)
 - declared cls: List()
 - enclosing   : class A (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$C / A.C (canon) / C (simple)
 - declared cls: List()
 - enclosing   : class A (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$D$ / A.D$ (canon) / D$ (simple)
 - declared cls: List(class A$D$B, interface A$D$C, class A$D$D$)
 - enclosing   : class A (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$D$$anon$1 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A$D$ (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class A$D$$anon$1 is anonymous
 assert not class A$D$$anon$1
 A$D$B / A.D$.B (canon) / B (simple)
 - declared cls: List()
 - enclosing   : class A$D$ (declaring cls) / class A$D$ (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$D$C / A.D$.C (canon) / C (simple)
 - declared cls: List()
 - enclosing   : class A$D$ (declaring cls) / class A$D$ (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$D$D$ / A.D$.D$ (canon) / D$ (simple)
 - declared cls: List()
 - enclosing   : class A$D$ (declaring cls) / class A$D$ (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 A$D$KB$1 / null (canon) / KB$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A$D$ (cls) / null (constr) / public void A$D$.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$E$1 / null (canon) / E$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$F$1 / null (canon) / F$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$G$1$ / null (canon) / G$1$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$H$1 / null (canon) / H$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$I$1 / null (canon) / I$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$J$1$ / null (canon) / J$1$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / public java.lang.Object A.f() (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$K$1 / null (canon) / K$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$L$1 / null (canon) / L$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$M$1$ / null (canon) / M$1$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$N$1 / null (canon) / N$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$O$1 / null (canon) / O$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$P$1$ / null (canon) / P$1$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / null (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$Q$1 / null (canon) / Q$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / public A(int) (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$R$1 / null (canon) / R$1 (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / public A(int) (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 A$S$1$ / null (canon) / S$1$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class A (cls) / public A(int) (constr) / null (meth)
 - properties  : true (local) / false (member)
-isAnonymous? false
 AO / AO (canon) / AO (simple)
 - declared cls: List(class AO$B, interface AO$C, class AO$D$)
 - enclosing   : null (declaring cls) / null (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? false
 AO$ / AO$ (canon) / AO$ (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / null (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? false
 AO$$anon$8 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / class AO$ (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class AO$$anon$8 is anonymous
 assert not class AO$$anon$8
 AO$B / AO.B (canon) / B (simple)
 - declared cls: List()
 - enclosing   : class AO (declaring cls) / class AO (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 AO$C / AO.C (canon) / C (simple)
 - declared cls: List()
 - enclosing   : class AO (declaring cls) / class AO (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 AO$D$ / AO.D$ (canon) / D$ (simple)
 - declared cls: List()
 - enclosing   : class AO (declaring cls) / class AO (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 AT / AT (canon) / AT (simple)
 - declared cls: List(class AT$B, interface AT$C, class AT$D$)
 - enclosing   : null (declaring cls) / null (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? false
 AT$$anon$9 / null (canon) /  (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / interface AT (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? true
+assert not class AT$$anon$9 is anonymous
 assert not class AT$$anon$9
 AT$B / AT.B (canon) / B (simple)
 - declared cls: List()
 - enclosing   : interface AT (declaring cls) / interface AT (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 AT$C / AT.C (canon) / C (simple)
 - declared cls: List()
 - enclosing   : interface AT (declaring cls) / interface AT (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 AT$D$ / AT.D$ (canon) / D$ (simple)
 - declared cls: List()
 - enclosing   : interface AT (declaring cls) / interface AT (cls) / null (constr) / null (meth)
 - properties  : false (local) / true (member)
-isAnonymous? false
 T / T (canon) / T (simple)
 - declared cls: List()
 - enclosing   : null (declaring cls) / null (cls) / null (constr) / null (meth)
 - properties  : false (local) / false (member)
-isAnonymous? false

# 0/1 passed, 1 failed in jvm

# Failed test paths (this command will update checkfiles)
partest --update-check \
  /Users/jz/code/scala/test/files/run/t6146b.scala \
  /Users/jz/code/scala/test/files/jvm/javaReflection

As well as:

[error] - bench/compile
[error]   - bench/compile:compileIncremental failed: Compilation failed
[error] - doc

[som-snytt]

I was eager to understand the bench fails but had a busy weekend. It wasn't immediately obvious if it was an sbt-jmh versioning or what. I saw some classpath manipulation in the plugin, but got time boxed.

[retronym]

I lost an edit to the to comment above. The compilation of bench is fixed by upgrading STARR to 2.13.x which contains ASM 6.2. CI uses boostraps before testAll so it should already be fine there.

For the doc, we need to exclude module-info.class from getting a ClassSymbol. module-info is not a valid class name so PackageLoader should exclude it. Scaladoc hits this because it enumerates all package members and calls .info. https://github.com/retronym/scala/tree/topic/module-info collects fragments of the fix.